You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/06/05 08:45:37 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #20490: [improve][broker] Improve efficiency of checking message deletion

lhotari opened a new pull request, #20490:
URL: https://github.com/apache/pulsar/pull/20490

   ### Motivation
   
   Currently deleted messages are checked in the order that individual messages are checked first and then comparing the mark delete position after this. Since the check for the mark delete position is a simple check, it's more efficient to check that first.
   
   ### Modifications
   
   - change order of condition evaluation
   - omit creation of PositionImpl instances in trimDeletedEntries
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun merged pull request #20490: [improve][broker] Improve efficiency of checking message deletion

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #20490:
URL: https://github.com/apache/pulsar/pull/20490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #20490: [improve][broker] Improve efficiency of checking message deletion

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20490:
URL: https://github.com/apache/pulsar/pull/20490#issuecomment-1577955953

   Merging...
   
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org