[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #534: Updated byte symbol for undefinedCharStandIn

["Shanedell (via GitHub)" <gi...@apache.org>]

Shanedell commented on code in PR #534:
URL: https://github.com/apache/daffodil-vscode/pull/534#discussion_r1150994935


##########
src/omega_edit/utils.ts:
##########
@@ -94,7 +94,7 @@ export function logicalDisplay(
   bytes: ArrayBuffer,
   bytesPerRow: number
 ): string {
-  const undefinedCharStandIn = '�'
+  const undefinedCharStandIn = '░'

Review Comment:
   Is there a way to use an ascii code that when converted to a string it will give this value? Just thinking if we used a ascii code or something then convert it to a string if it produces the same result it would look cleaner that having this weird symbol in there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org