You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "slim bouguerra (JIRA)" <ji...@apache.org> on 2019/03/25 19:33:00 UTC

[jira] [Comment Edited] (HIVE-21204) Instrumentation for read/write locks in LLAP

    [ https://issues.apache.org/jira/browse/HIVE-21204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800994#comment-16800994 ] 

slim bouguerra edited comment on HIVE-21204 at 3/25/19 7:32 PM:
----------------------------------------------------------------

pushed to master (missed some files sorry !)
https://git-wip-us.apache.org/repos/asf?p=hive.git;a=commit;h=c3ec20dd4f5b5fbde4007041844f6aed8c262ca1
and 
https://git-wip-us.apache.org/repos/asf?p=hive.git;a=commit;h=b01258b7a592033fdae4dc2deefe2e2f5cfd740d


was (Author: bslim):
pushed to master 
https://git-wip-us.apache.org/repos/asf?p=hive.git;a=commit;h=c3ec20dd4f5b5fbde4007041844f6aed8c262ca1


> Instrumentation for read/write locks in LLAP
> --------------------------------------------
>
>                 Key: HIVE-21204
>                 URL: https://issues.apache.org/jira/browse/HIVE-21204
>             Project: Hive
>          Issue Type: Improvement
>          Components: llap
>            Reporter: Oliver Draese
>            Assignee: Oliver Draese
>            Priority: Major
>         Attachments: HIVE-21204.4.patch, HIVE-21204.5.patch, HIVE-21204.6.patch
>
>
> LLAP has several R/W locks for serialization of updates to query tracker, file data, ....
> Instrumentation is added to monitor the
>  * total amount of R/W locks within a particular category
>  * average + max wait/suspension time to get the R/W lock
> A category includes all lock instances for particular areas (i.e. category is FileData and all R/W locks that are used in FileData instances are accounted within the one category).
> The monitoring/accounting is done via Hadoop Metrics 2, making them accessible via JMX. In addition, a new "locking" GET endpoint is added to the LLAP daemon's REST interface. It produces output like the following example:
> {
>  {{  "statsCollection": "enabled",}}
>  {{  "lockStats": [}}
>  {{    {}}{{ "type": "R/W Lock Stats",}}
>  {{      "label": "FileData",}}
>  {{      "totalLockWaitTimeMillis": 0,}}
>  {{      "readLock": {}}
>  {{         "count": 0,}}
>  {{         "avgWaitTimeNanos": 0,}}
>  {{         "maxWaitTimeNanos": 0}}
>  {{      },}}
>  {{      "writeLock": {}}
>  {{         "count": 0,}}
>  {{         "avgWaitTimeNanos": 0,}}
>  {{         "maxWaitTimeNanos": 0}}
>               }
>  {{    },}}
>  {{    { "}}{{type": "R/W Lock Stats",}}
>  {{      "label": "QueryTracker",}}
>  {{      "totalLockWaitTimeMillis": 0,}}
>  {{      "readLock": {}}
>  {{         "count": 0,}}
>  {{         "avgWaitTimeNanos": 0,}}
>  {{         "maxWaitTimeNanos": 0}}
>  {{      },}}
>  {{      "writeLock": {}}
>  {{         "count": 0,}}
>  {{         "avgWaitTimeNanos": 0,}}
>  {{         "maxWaitTimeNanos": 0}}
>               }
>  {{    } }}{{]}}
> {{}}}
> To avoid the overhead of lock instrumentation, lock metrics collection is disabled by default and can be enabled via the following configuration parameter:
>   {{hive.llap.lockmetrics.collect = true}}
>   
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)