You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "socutes (via GitHub)" <gi...@apache.org> on 2023/03/16 13:12:37 UTC

[GitHub] [rocketmq] socutes opened a new pull request, #6375: [ISSUE #6373] Optimized log printing and fixed null pointer exceptions

socutes opened a new pull request, #6375:
URL: https://github.com/apache/rocketmq/pull/6375

   close #6373


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] codecov-commenter commented on pull request #6375: [ISSUE #6373] Optimized log printing and fixed null pointer exceptions

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6375:
URL: https://github.com/apache/rocketmq/pull/6375#issuecomment-1474157999

   ## [Codecov](https://codecov.io/gh/apache/rocketmq/pull/6375?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6375](https://codecov.io/gh/apache/rocketmq/pull/6375?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0ef8b40) into [develop](https://codecov.io/gh/apache/rocketmq/commit/5ac91199f2c64be9f221dec7c25acb5e84cf91cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ac9119) will **decrease** coverage by `0.02%`.
   > The diff coverage is `53.33%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #6375      +/-   ##
   =============================================
   - Coverage      43.07%   43.06%   -0.02%     
   + Complexity      8914     8912       -2     
   =============================================
     Files           1105     1105              
     Lines          77943    77956      +13     
     Branches       10144    10145       +1     
   =============================================
   - Hits           33575    33570       -5     
   - Misses         40151    40176      +25     
   + Partials        4217     4210       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/6375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/rocketmq/proxy/ProxyStartup.java](https://codecov.io/gh/apache/rocketmq/pull/6375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L1Byb3h5U3RhcnR1cC5qYXZh) | `44.34% <0.00%> (ø)` | |
   | [...tmq/proxy/service/mqclient/MQClientAPIFactory.java](https://codecov.io/gh/apache/rocketmq/pull/6375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2UvbXFjbGllbnQvTVFDbGllbnRBUElGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/6375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `46.75% <63.63%> (+0.14%)` | :arrow_up: |
   | [...rg/apache/rocketmq/proxy/config/Configuration.java](https://codecov.io/gh/apache/rocketmq/pull/6375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbmZpZy9Db25maWd1cmF0aW9uLmphdmE=) | `72.41% <100.00%> (+0.98%)` | :arrow_up: |
   
   ... and [19 files with indirect coverage changes](https://codecov.io/gh/apache/rocketmq/pull/6375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] fuyou001 commented on a diff in pull request #6375: [ISSUE #6373] Optimized log printing and fixed null pointer exceptions

Posted by "fuyou001 (via GitHub)" <gi...@apache.org>.
fuyou001 commented on code in PR #6375:
URL: https://github.com/apache/rocketmq/pull/6375#discussion_r1138888915


##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/mqclient/MQClientAPIFactory.java:
##########
@@ -55,6 +55,9 @@ protected void init() {
         System.setProperty(ClientConfig.SEND_MESSAGE_WITH_VIP_CHANNEL_PROPERTY, "false");
         ProxyConfig proxyConfig = ConfigurationManager.getProxyConfig();
         if (StringUtils.isEmpty(proxyConfig.getNamesrvDomain())) {
+            if (proxyConfig.getNamesrvAddr() == null) {

Review Comment:
   if namesrvAddr is empty?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] socutes commented on pull request #6375: [ISSUE #6373] Optimized log printing and fixed null pointer exceptions

Posted by "socutes (via GitHub)" <gi...@apache.org>.
socutes commented on PR #6375:
URL: https://github.com/apache/rocketmq/pull/6375#issuecomment-1474566337

   @xdkxlk PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] zhouxinyu merged pull request #6375: [ISSUE #6373] Optimized log printing and fixed null pointer exceptions

Posted by "zhouxinyu (via GitHub)" <gi...@apache.org>.
zhouxinyu merged PR #6375:
URL: https://github.com/apache/rocketmq/pull/6375


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] fuyou001 commented on a diff in pull request #6375: [ISSUE #6373] Optimized log printing and fixed null pointer exceptions

Posted by "fuyou001 (via GitHub)" <gi...@apache.org>.
fuyou001 commented on code in PR #6375:
URL: https://github.com/apache/rocketmq/pull/6375#discussion_r1138889321


##########
proxy/src/main/java/org/apache/rocketmq/proxy/ProxyStartup.java:
##########
@@ -100,7 +100,7 @@ public static void main(String[] args) {
                 }
             }));
         } catch (Exception e) {
-            System.err.println("find an unexpect err." + e);
+            e.printStackTrace();

Review Comment:
   delete



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] zhouxinyu commented on a diff in pull request #6375: [ISSUE #6373] Optimized log printing and fixed null pointer exceptions

Posted by "zhouxinyu (via GitHub)" <gi...@apache.org>.
zhouxinyu commented on code in PR #6375:
URL: https://github.com/apache/rocketmq/pull/6375#discussion_r1141687164


##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/mqclient/MQClientAPIFactory.java:
##########
@@ -55,6 +55,9 @@ protected void init() {
         System.setProperty(ClientConfig.SEND_MESSAGE_WITH_VIP_CHANNEL_PROPERTY, "false");
         ProxyConfig proxyConfig = ConfigurationManager.getProxyConfig();
         if (StringUtils.isEmpty(proxyConfig.getNamesrvDomain())) {
+            if (proxyConfig.getNamesrvAddr() == null || proxyConfig.getNamesrvAddr().isEmpty()) {

Review Comment:
   Try [isNullOrEmpty](https://guava.dev/releases/23.0/api/docs/com/google/common/base/Strings.html#isNullOrEmpty-java.lang.String-) to simplify this line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org