You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/05 09:26:59 UTC
[GitHub] [spark] wangyum opened a new pull request #33914: vvvvcchhgrdnhljftuvfejeecuhiulbkginuclffteknSpark 32268 2
wangyum opened a new pull request #33914:
URL: https://github.com/apache/spark/pull/33914
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] PengleiShi commented on a change in pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
PengleiShi commented on a change in pull request #33914:
URL: https://github.com/apache/spark/pull/33914#discussion_r733515433
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/DynamicBloomFilterPruning.scala
##########
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.dynamicpruning
+
+import org.apache.spark.sql.catalyst.expressions._
+import org.apache.spark.sql.catalyst.expressions.aggregate.BuildBloomFilter
+import org.apache.spark.sql.catalyst.optimizer.JoinSelectionHelper
+import org.apache.spark.sql.catalyst.plans.logical._
+import org.apache.spark.sql.catalyst.plans.logical.statsEstimation.EstimationUtils
+import org.apache.spark.sql.catalyst.rules.Rule
+
+/**
+ * Dynamic bloom filter pruning optimization is performed based on the type and
+ * selectivity of the join operation. During query optimization, we insert a
+ * predicate on the filterable table using the filter from the other side of
+ * the join and a custom wrapper called DynamicPruning.
+ */
+object DynamicBloomFilterPruning extends Rule[LogicalPlan]
+ with PredicateHelper
+ with JoinSelectionHelper
+ with DynamicPruningHelper {
+
+ private def getFilterableTableScan(
+ exp: Expression,
+ plan: LogicalPlan): Option[LogicalPlan] = plan match {
+ case p @ Project(_, child) =>
+ getFilterableTableScan(replaceAlias(exp, getAliasMap(p)), child)
+ // we can unwrap only if there are row projections, and no aggregation operation
+ case a @ Aggregate(_, _, child) =>
+ getFilterableTableScan(replaceAlias(exp, getAliasMap(a)), child)
+ case f @ Filter(_, l: LeafNode)
+ if exp.references.subsetOf(f.outputSet) && exp.references.subsetOf(l.outputSet) =>
+ Some(f)
+ case l: LeafNode if exp.references.subsetOf(l.outputSet) =>
+ Some(l)
+ case other =>
+ other.children.flatMap {
+ child => if (exp.references.subsetOf(child.outputSet)) {
+ getFilterableTableScan(exp, child)
+ } else {
+ None
+ }
+ }.headOption
+ }
+
+ private def rowCounts(plan: LogicalPlan): BigInt = {
+ plan.stats.rowCount
+ .getOrElse(plan.stats.sizeInBytes / EstimationUtils.getSizePerRow(plan.output))
+ }
+
+ /**
+ * Insert a dynamic bloom filter pruning predicate on one side of the join using the filter on the
+ * other side of the join.
+ * - to be able to identify this filter during query planning, we use a custom
+ * DynamicPruning expression that wraps a regular InBloomFilter expression
+ */
+ private def insertPredicate(
+ pruningKey: Expression,
+ pruningPlan: LogicalPlan,
+ filteringKey: Expression,
+ filteringPlan: LogicalPlan,
+ joinKeys: Seq[Expression],
+ distinctCnt: Option[BigInt],
+ rowCount: BigInt): LogicalPlan = {
+ val expectedNumItems = distinctCnt.getOrElse(rowCount)
+ val coalescePartitions = math.max(math.ceil(expectedNumItems.toDouble / 4000000.0).toInt, 1)
+ // Use EnsureRequirements shuffle origin to reuse the exchange.
+ val repartition = RepartitionByExpression(joinKeys, filteringPlan,
+ optNumPartitions = Some(conf.numShufflePartitions),
+ withEnsureRequirementsShuffleOrigin = true)
+ // Coalesce partitions to improve build bloom filter performance.
+ val coalesce = Repartition(coalescePartitions, shuffle = false, repartition)
+ val bloomFilter = Aggregate(Nil,
+ Seq(BuildBloomFilter(filteringKey, expectedNumItems.toLong, distinctCnt.isEmpty, 0, 0)
+ .toAggregateExpression()).map(e => Alias(e, e.sql)()), coalesce)
+
+ Filter(
+ DynamicBloomFilterPruningSubquery(
+ pruningKey,
+ bloomFilter,
+ joinKeys,
+ joinKeys.indexOf(filteringKey)),
+ pruningPlan)
+ }
+
+ private def pruningHasBenefit(
+ filteringRowCount: BigInt,
+ filteringDistinctCnt: Option[BigInt],
+ pruningDistinctCnt: Option[BigInt],
+ pruningScan: LogicalPlan): Boolean = {
+ val filterRatio = filteringDistinctCnt
+ .flatMap(x => pruningDistinctCnt.map(x.toFloat / _.toFloat)).filter(_ < 1.0).map(1.0 - _)
+ .getOrElse(conf.dynamicPartitionPruningPruningSideExtraFilterRatio)
+ filteringRowCount.toFloat / (rowCounts(pruningScan).toFloat * filterRatio) < 0.04
Review comment:
If `filterRatio ` uses the default value 0.04, that is `filteringRowCount` should be less than pruningRowCount * 0.04 * 0.04, could you explain the purpose？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913153632
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142999/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-916048628
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143114/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915881728
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47616/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913154108
**[Test build #143000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143000/testReport)** for PR 33914 at commit [`c7a7266`](https://github.com/apache/spark/commit/c7a7266460c7a483210b32b5383bd53069d6f906).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-916037369
**[Test build #143114 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143114/testReport)** for PR 33914 at commit [`1929f30`](https://github.com/apache/spark/commit/1929f30e3335b90b9e78357f76e247167e69b901).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915082161
> I think we should probably at least have a design doc to explain this .. from a cursory look the change looks huge.
I’m still doing an evaluation in our production environment, and I’ll prepare the design doc after the evaluation done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915116050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915101769
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47583/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915155235
**[Test build #143084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143084/testReport)** for PR 33914 at commit [`57770e8`](https://github.com/apache/spark/commit/57770e82b0a4d55966a42d51503c09587af1df43).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913150144
**[Test build #142999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142999/testReport)** for PR 33914 at commit [`6a82c18`](https://github.com/apache/spark/commit/6a82c18095576808969a06875cad677c4d8965bf).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913134379
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47500/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915881798
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47616/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915096074
**[Test build #143081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143081/testReport)** for PR 33914 at commit [`b535d6c`](https://github.com/apache/spark/commit/b535d6c6d74b330772dd06a93caf42386fcd97ca).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jaceklaskowski commented on a change in pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
jaceklaskowski commented on a change in pull request #33914:
URL: https://github.com/apache/spark/pull/33914#discussion_r703286889
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -353,6 +353,23 @@ object SQLConf {
.checkValue(ratio => ratio > 0.0 && ratio <= 1.0, "The ratio value must be in (0.0, 1.0].")
.createWithDefault(0.04)
+ val DYNAMIC_BLOOM_FILTER_JOIN_PRUNING_ENABLED =
+ buildConf("spark.sql.optimizer.dynamicBloomFilterJoinPruning.enabled")
+ .doc("When true, we will generate bloom filter predicate for column when it's used as join " +
Review comment:
nit: "generates a bloom filter predicate for a join key column"
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -353,6 +353,23 @@ object SQLConf {
.checkValue(ratio => ratio > 0.0 && ratio <= 1.0, "The ratio value must be in (0.0, 1.0].")
.createWithDefault(0.04)
+ val DYNAMIC_BLOOM_FILTER_JOIN_PRUNING_ENABLED =
+ buildConf("spark.sql.optimizer.dynamicBloomFilterJoinPruning.enabled")
+ .doc("When true, we will generate bloom filter predicate for column when it's used as join " +
+ "key. Note that, dynamic bloom filter join pruning only works if exchange reuse enabled.")
+ .version("3.3.0")
+ .booleanConf
+ .createWithDefault(true)
+
+ val DYNAMIC_BLOOM_FILTER_JOIN_PRUNING_MAX_BLOOM_FILTER_ENTRIES =
+ buildConf("spark.sql.optimizer.dynamicBloomFilterJoinPruning.maxBloomFilterEntries")
+ .doc("The maximum number of bloom filter entries allowed when building dynamic bloom filter" +
Review comment:
nit: s/when building/for
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -353,6 +353,23 @@ object SQLConf {
.checkValue(ratio => ratio > 0.0 && ratio <= 1.0, "The ratio value must be in (0.0, 1.0].")
.createWithDefault(0.04)
+ val DYNAMIC_BLOOM_FILTER_JOIN_PRUNING_ENABLED =
+ buildConf("spark.sql.optimizer.dynamicBloomFilterJoinPruning.enabled")
+ .doc("When true, we will generate bloom filter predicate for column when it's used as join " +
+ "key. Note that, dynamic bloom filter join pruning only works if exchange reuse enabled.")
Review comment:
Use the config property so it becomes `s"only works with ${SQLConf.EXCHANGE_REUSE_ENABLED.key} enabled"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913135531
**[Test build #142998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142998/testReport)** for PR 33914 at commit [`a0b11f5`](https://github.com/apache/spark/commit/a0b11f5432cd71823b5c84f14a1b5bb957f23c9d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915182284
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913135578
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142998/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913117543
**[Test build #142998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142998/testReport)** for PR 33914 at commit [`a0b11f5`](https://github.com/apache/spark/commit/a0b11f5432cd71823b5c84f14a1b5bb957f23c9d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915384684
**[Test build #143084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143084/testReport)** for PR 33914 at commit [`57770e8`](https://github.com/apache/spark/commit/57770e82b0a4d55966a42d51503c09587af1df43).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913134379
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47500/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915195252
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913928239
I think we should probably at least have a design doc to explain this .. from a cursory look the change looks huge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913120675
Example of TPC-DS q37.
Before this PR | After this PR
--- | ---
 | 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum edited a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
wangyum edited a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913120675
Example of TPC-DS q37.
Before this PR | After this PR
--- | ---
 | 
Real case from cluster:
Before this PR | After this PR
--- | ---
 | 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #33914:
URL: https://github.com/apache/spark/pull/33914#discussion_r704250838
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -353,6 +353,23 @@ object SQLConf {
.checkValue(ratio => ratio > 0.0 && ratio <= 1.0, "The ratio value must be in (0.0, 1.0].")
.createWithDefault(0.04)
+ val DYNAMIC_BLOOM_FILTER_JOIN_PRUNING_ENABLED =
+ buildConf("spark.sql.optimizer.dynamicBloomFilterJoinPruning.enabled")
+ .doc("When true, we will generate bloom filter predicate for column when it's used as join " +
Review comment:
Thank you @jaceklaskowski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913162040
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47502/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913153632
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142999/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915116050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913135578
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142998/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913117543
**[Test build #142998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142998/testReport)** for PR 33914 at commit [`a0b11f5`](https://github.com/apache/spark/commit/a0b11f5432cd71823b5c84f14a1b5bb957f23c9d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915195252
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913144385
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47501/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915852979
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47616/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915092363
**[Test build #143081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143081/testReport)** for PR 33914 at commit [`b535d6c`](https://github.com/apache/spark/commit/b535d6c6d74b330772dd06a93caf42386fcd97ca).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913144385
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47501/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915387701
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143084/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915881798
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47616/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913129664
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47500/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913131990
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47501/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915837952
**[Test build #143114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143114/testReport)** for PR 33914 at commit [`1929f30`](https://github.com/apache/spark/commit/1929f30e3335b90b9e78357f76e247167e69b901).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915155235
**[Test build #143084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143084/testReport)** for PR 33914 at commit [`57770e8`](https://github.com/apache/spark/commit/57770e82b0a4d55966a42d51503c09587af1df43).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915092363
**[Test build #143081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143081/testReport)** for PR 33914 at commit [`b535d6c`](https://github.com/apache/spark/commit/b535d6c6d74b330772dd06a93caf42386fcd97ca).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] PengleiShi commented on a change in pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
PengleiShi commented on a change in pull request #33914:
URL: https://github.com/apache/spark/pull/33914#discussion_r733515433
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/DynamicBloomFilterPruning.scala
##########
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.dynamicpruning
+
+import org.apache.spark.sql.catalyst.expressions._
+import org.apache.spark.sql.catalyst.expressions.aggregate.BuildBloomFilter
+import org.apache.spark.sql.catalyst.optimizer.JoinSelectionHelper
+import org.apache.spark.sql.catalyst.plans.logical._
+import org.apache.spark.sql.catalyst.plans.logical.statsEstimation.EstimationUtils
+import org.apache.spark.sql.catalyst.rules.Rule
+
+/**
+ * Dynamic bloom filter pruning optimization is performed based on the type and
+ * selectivity of the join operation. During query optimization, we insert a
+ * predicate on the filterable table using the filter from the other side of
+ * the join and a custom wrapper called DynamicPruning.
+ */
+object DynamicBloomFilterPruning extends Rule[LogicalPlan]
+ with PredicateHelper
+ with JoinSelectionHelper
+ with DynamicPruningHelper {
+
+ private def getFilterableTableScan(
+ exp: Expression,
+ plan: LogicalPlan): Option[LogicalPlan] = plan match {
+ case p @ Project(_, child) =>
+ getFilterableTableScan(replaceAlias(exp, getAliasMap(p)), child)
+ // we can unwrap only if there are row projections, and no aggregation operation
+ case a @ Aggregate(_, _, child) =>
+ getFilterableTableScan(replaceAlias(exp, getAliasMap(a)), child)
+ case f @ Filter(_, l: LeafNode)
+ if exp.references.subsetOf(f.outputSet) && exp.references.subsetOf(l.outputSet) =>
+ Some(f)
+ case l: LeafNode if exp.references.subsetOf(l.outputSet) =>
+ Some(l)
+ case other =>
+ other.children.flatMap {
+ child => if (exp.references.subsetOf(child.outputSet)) {
+ getFilterableTableScan(exp, child)
+ } else {
+ None
+ }
+ }.headOption
+ }
+
+ private def rowCounts(plan: LogicalPlan): BigInt = {
+ plan.stats.rowCount
+ .getOrElse(plan.stats.sizeInBytes / EstimationUtils.getSizePerRow(plan.output))
+ }
+
+ /**
+ * Insert a dynamic bloom filter pruning predicate on one side of the join using the filter on the
+ * other side of the join.
+ * - to be able to identify this filter during query planning, we use a custom
+ * DynamicPruning expression that wraps a regular InBloomFilter expression
+ */
+ private def insertPredicate(
+ pruningKey: Expression,
+ pruningPlan: LogicalPlan,
+ filteringKey: Expression,
+ filteringPlan: LogicalPlan,
+ joinKeys: Seq[Expression],
+ distinctCnt: Option[BigInt],
+ rowCount: BigInt): LogicalPlan = {
+ val expectedNumItems = distinctCnt.getOrElse(rowCount)
+ val coalescePartitions = math.max(math.ceil(expectedNumItems.toDouble / 4000000.0).toInt, 1)
+ // Use EnsureRequirements shuffle origin to reuse the exchange.
+ val repartition = RepartitionByExpression(joinKeys, filteringPlan,
+ optNumPartitions = Some(conf.numShufflePartitions),
+ withEnsureRequirementsShuffleOrigin = true)
+ // Coalesce partitions to improve build bloom filter performance.
+ val coalesce = Repartition(coalescePartitions, shuffle = false, repartition)
+ val bloomFilter = Aggregate(Nil,
+ Seq(BuildBloomFilter(filteringKey, expectedNumItems.toLong, distinctCnt.isEmpty, 0, 0)
+ .toAggregateExpression()).map(e => Alias(e, e.sql)()), coalesce)
+
+ Filter(
+ DynamicBloomFilterPruningSubquery(
+ pruningKey,
+ bloomFilter,
+ joinKeys,
+ joinKeys.indexOf(filteringKey)),
+ pruningPlan)
+ }
+
+ private def pruningHasBenefit(
+ filteringRowCount: BigInt,
+ filteringDistinctCnt: Option[BigInt],
+ pruningDistinctCnt: Option[BigInt],
+ pruningScan: LogicalPlan): Boolean = {
+ val filterRatio = filteringDistinctCnt
+ .flatMap(x => pruningDistinctCnt.map(x.toFloat / _.toFloat)).filter(_ < 1.0).map(1.0 - _)
+ .getOrElse(conf.dynamicPartitionPruningPruningSideExtraFilterRatio)
+ filteringRowCount.toFloat / (rowCounts(pruningScan).toFloat * filterRatio) < 0.04
Review comment:
If `filterRatio ` uses the default value 0.04, that is `filteringRowCount` should be less than pruningRowCount * 0.04 * 0.04, could you explain the purpose？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913141290
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47501/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913124901
**[Test build #142999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142999/testReport)** for PR 33914 at commit [`6a82c18`](https://github.com/apache/spark/commit/6a82c18095576808969a06875cad677c4d8965bf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913154999
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143000/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #33914:
URL: https://github.com/apache/spark/pull/33914#discussion_r704258121
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -353,6 +353,23 @@ object SQLConf {
.checkValue(ratio => ratio > 0.0 && ratio <= 1.0, "The ratio value must be in (0.0, 1.0].")
.createWithDefault(0.04)
+ val DYNAMIC_BLOOM_FILTER_JOIN_PRUNING_ENABLED =
+ buildConf("spark.sql.optimizer.dynamicBloomFilterJoinPruning.enabled")
+ .doc("When true, we will generate bloom filter predicate for column when it's used as join " +
+ "key. Note that, dynamic bloom filter join pruning only works if exchange reuse enabled.")
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913160593
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47502/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913154108
**[Test build #143000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143000/testReport)** for PR 33914 at commit [`c7a7266`](https://github.com/apache/spark/commit/c7a7266460c7a483210b32b5383bd53069d6f906).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #33914:
URL: https://github.com/apache/spark/pull/33914#discussion_r704260274
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -353,6 +353,23 @@ object SQLConf {
.checkValue(ratio => ratio > 0.0 && ratio <= 1.0, "The ratio value must be in (0.0, 1.0].")
.createWithDefault(0.04)
+ val DYNAMIC_BLOOM_FILTER_JOIN_PRUNING_ENABLED =
+ buildConf("spark.sql.optimizer.dynamicBloomFilterJoinPruning.enabled")
+ .doc("When true, we will generate bloom filter predicate for column when it's used as join " +
+ "key. Note that, dynamic bloom filter join pruning only works if exchange reuse enabled.")
+ .version("3.3.0")
+ .booleanConf
+ .createWithDefault(true)
+
+ val DYNAMIC_BLOOM_FILTER_JOIN_PRUNING_MAX_BLOOM_FILTER_ENTRIES =
+ buildConf("spark.sql.optimizer.dynamicBloomFilterJoinPruning.maxBloomFilterEntries")
+ .doc("The maximum number of bloom filter entries allowed when building dynamic bloom filter" +
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913123385
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47500/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915837952
**[Test build #143114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143114/testReport)** for PR 33914 at commit [`1929f30`](https://github.com/apache/spark/commit/1929f30e3335b90b9e78357f76e247167e69b901).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915188721
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-916048628
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143114/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-915387701
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143084/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913124901
**[Test build #142999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142999/testReport)** for PR 33914 at commit [`6a82c18`](https://github.com/apache/spark/commit/6a82c18095576808969a06875cad677c4d8965bf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913154989
**[Test build #143000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143000/testReport)** for PR 33914 at commit [`c7a7266`](https://github.com/apache/spark/commit/c7a7266460c7a483210b32b5383bd53069d6f906).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913154999
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143000/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913163450
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47502/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33914: [SPARK-32268][SQL] Dynamic bloom filter join pruning
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33914:
URL: https://github.com/apache/spark/pull/33914#issuecomment-913163450
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47502/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org