You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/06 20:56:00 UTC

[jira] [Commented] (KAFKA-9499) Improve deletion process by batching more aggressively

    [ https://issues.apache.org/jira/browse/KAFKA-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031927#comment-17031927 ] 

ASF GitHub Bot commented on KAFKA-9499:
---------------------------------------

dajac commented on pull request #8053: KAFKA-9499; Improve deletion process by batching more aggressively
URL: https://github.com/apache/kafka/pull/8053
 
 
   This PR speeds up the deletion process by doing the following:
   - Batch whenever possible to minimize the number of requests sent out to other brokers;
   - Use `liveReplicasForTopic` instead of `allLiveReplicas` which is way more efficient.
   
   The tests covers the code which has been updated thus I haven't extended the tests in this area. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve deletion process by batching more aggressively
> ------------------------------------------------------
>
>                 Key: KAFKA-9499
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9499
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: David Jacot
>            Assignee: David Jacot
>            Priority: Major
>
> I have noticed that the topics deletion process could be improve by batching topics here: [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/controller/TopicDeletionManager.scala#L354]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)