You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/10 04:30:09 UTC
[GitHub] [spark] iRakson commented on a change in pull request #26779:
[SPARK-30150][SQL]ADD FILE, ADD JAR,
LIST FILE & LIST JAR Command do not accept quoted path
iRakson commented on a change in pull request #26779: [SPARK-30150][SQL]ADD FILE, ADD JAR, LIST FILE & LIST JAR Command do not accept quoted path
URL: https://github.com/apache/spark/pull/26779#discussion_r355839806
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -221,7 +221,7 @@ statement
multipartIdentifier partitionSpec? #loadData
| TRUNCATE TABLE multipartIdentifier partitionSpec? #truncateTable
| MSCK REPAIR TABLE multipartIdentifier #repairTable
- | op=(ADD | LIST) identifier .*? #manageResource
+ | op=(ADD | LIST) identifier (STRING | .*?) #manageResource
Review comment:
i used `(STRING | .*?) ` because atleast a file path must be given to ADD/LIST commands.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org