[PR] sim(feat):support sim elf and dynamic libs package in post build [nuttx]

["xuxin930 (via GitHub)" <gi...@apache.org>]

xuxin930 opened a new pull request, #14658:
URL: https://github.com/apache/nuttx/pull/14658

   ## Summary
   
   This will support the compatibility of sim products in different versions of host environments.
   
   For example:
   A sim elf compiled in ubuntu22 can run in ubuntu20.
   This will be helpful when compiling in different dockers
   
   use the dynamic library .so of the binding compilation environment,
   and then modify the dynamic loader of elf at runtime to run sim elf across system versions
   
   1. add post-build for sim build
   2. collect dynamic .so and dynamic interpreter
   3. add execution script for the entire package sim elf
   
   ## Impact
   
   It is an enhanced function and should have no impact on previous
   
   ## Testing
   
   Build sim in ubuntu22
   Start elf in ubuntu20
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] sim(feat):support sim elf and dynamic libs package in post build [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #14658:
URL: https://github.com/apache/nuttx/pull/14658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] sim(feat):support sim elf and dynamic libs package in post build [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #14658:
URL: https://github.com/apache/nuttx/pull/14658#issuecomment-2457104420

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   Yes, this PR appears to mostly meet the NuttX requirements, but needs more detail in a few key areas.  Specifically, it needs more details in the "Impact" and "Testing" sections.
   
   Here's a breakdown of what's missing and suggestions for improvement:
   
   **Missing Information/Areas for Improvement:**
   
   * **Summary:** While the summary explains the "why," it's light on the "how."  It mentions modifying the dynamic loader, but doesn't explain *how* that modification happens.  More technical detail is needed. What files are changed? What specific code is added or modified?
   
   * **Impact:**  Saying "no impact" is unlikely.  While *users* may not see a change in functionality, there *are* changes to the build process.  This section needs to be filled out more completely.  Consider:
       * **Impact on build (will build process change)?** YES (post-build step added for sim builds)
       * **Impact on compatibility (backward/forward/interoperability)?**  Potentially YES - Explain how this impacts running older sim builds.  Will they still work?
       * **Anything else to consider?**  Mention any potential downsides (increased build time, larger output size).
   
   * **Testing:** The testing section is too brief.  Provide concrete examples of commands used and output observed.  "Start elf in ubuntu20" is insufficient.  Show the actual commands and the output demonstrating the successful execution in both environments.  Include examples of any errors encountered *before* the change, and how they are resolved *after* the change.
   
   **Example of Improved Testing Section:**
   
   ```
   Testing:
   
   Build Host: Ubuntu 22.04, x86_64, GCC 11.2.0
   Target: sim:nsh
   
   Testing logs before change (Ubuntu 20.04):
   
   ```bash
   $ ./nuttx
   ./nuttx: error while loading shared libraries: libxxx.so.y: cannot open shared object file: No such file or directory
   ```
   
   Testing logs after change (Ubuntu 20.04):
   
   ```bash
   $ ./run_sim.sh  # (Or whatever the new script is called)
   NuttShell (NSH)
   nsh> help
   ... (Output of the help command, demonstrating successful execution)
   ```
   ```
   
   **Key Takeaway:**  Provide more specifics.  Think about what a reviewer unfamiliar with your work would need to know to understand and evaluate the changes.  More detail leads to faster reviews and a smoother PR process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org