[GitHub] [kylin] nichunen commented on a change in pull request #757: KYLIN-3917: Add max segment merge span to cleanup intermediate data of cube building

[GitBox <gi...@apache.org>]

nichunen commented on a change in pull request #757: KYLIN-3917: Add max segment merge span to cleanup intermediate data of cube building
URL: https://github.com/apache/kylin/pull/757#discussion_r339389488
 
 

 ##########
 File path: core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java
 ##########
 @@ -189,6 +195,21 @@ public void removeLatestSegmentByVolatileRange(Segments<T> segs, long volatileRa
 
     }
 
+    public void removeMaxSpanSegment(Segments<T> segs, long maxSegSpan) {
+        if (maxSegSpan <= 0) {
+            return;
+        }
+        Segments maxSpanSegs = new Segments();
+        for (T seg : segs) {
 
 Review comment:
   @lshmouse OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services