You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2015/10/16 12:24:05 UTC
Review Request 39391: [FALCON-1546] Add ProcessUpdateTest,
InstanceDependencyTest and other tests and test fixes contributed by Raghav
Gautam and Paul Isaychuk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39391/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1546
https://issues.apache.org/jira/browse/FALCON-1546
Repository: falcon-git
Description
-------
Set of new tests and test fixes
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java ba1d228
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java b905bee
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 83d06a2
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 10463c2
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java 9d028fa
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 83547e7
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java d956549
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 0fbfc38
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java PRE-CREATION
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java f3a107c
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/LoginPage.java 3193d21
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/MirrorWizardPage.java 6dfa1ca
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java 2a75b20
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java 706328f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 0662562
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 9ac9f24
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7f1e445
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java 9ea8471
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 1c788a3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java a64bd6d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/RecipeExecLocation.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java be8a631
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java b0ddcf3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java 47b1d19
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java 20864f6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java 552c15e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java c54789b
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java 728646f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java d11411b
Diff: https://reviews.apache.org/r/39391/diff/
Testing
-------
Thanks,
Paul Isaychuk
Re: Review Request 39391: [FALCON-1546] Add ProcessUpdateTest,
InstanceDependencyTest and other tests and test fixes contributed by Raghav
Gautam and Paul Isaychuk
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39391/#review102946
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java (line 100)
<https://reviews.apache.org/r/39391/#comment160772>
I am not sure why we have added an addProperty() method. Existing withProperty() can be used in all the places that you would use addProperty() ?
- Raghav Gautam
On Oct. 16, 2015, 3:24 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39391/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 3:24 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1546
> https://issues.apache.org/jira/browse/FALCON-1546
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Set of new tests and test fixes
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java ba1d228
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java b905bee
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 83d06a2
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 10463c2
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java 9d028fa
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 83547e7
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java d956549
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 0fbfc38
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java PRE-CREATION
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java f3a107c
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/LoginPage.java 3193d21
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/MirrorWizardPage.java 6dfa1ca
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java 2a75b20
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java 706328f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 0662562
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 9ac9f24
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7f1e445
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java 9ea8471
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 1c788a3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java a64bd6d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/RecipeExecLocation.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java be8a631
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java b0ddcf3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java 47b1d19
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java 20864f6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java 552c15e
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java c54789b
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java 728646f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java d11411b
>
> Diff: https://reviews.apache.org/r/39391/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 39391: [FALCON-1546] Add ProcessUpdateTest,
InstanceDependencyTest and other tests and test fixes contributed by Raghav
Gautam and Paul Isaychuk
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39391/#review103123
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java (line 560)
<https://reviews.apache.org/r/39391/#comment161066>
instanceTime can be renamed to params which will give more readability.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java (line 502)
<https://reviews.apache.org/r/39391/#comment161068>
Instead of making it as a private function, consider it adding it to OozieUtil so that future test case can use the same method. I have encountered cases where this function would be helpful.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java (line 68)
<https://reviews.apache.org/r/39391/#comment161069>
Please rename the class to PipelineInstanceDependencyTestand add it under 'triage' package.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java (line 331)
<https://reviews.apache.org/r/39391/#comment161070>
This can be added as a public method in EntityLineageUtil.java
- PRAGYA MITTAL
On Oct. 19, 2015, 12:27 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39391/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 12:27 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1546
> https://issues.apache.org/jira/browse/FALCON-1546
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Set of new tests and test fixes
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java b905bee
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 83d06a2
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 10463c2
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java 9d028fa
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 83547e7
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java d956549
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 0fbfc38
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java PRE-CREATION
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java f3a107c
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/LoginPage.java 3193d21
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/MirrorWizardPage.java 6dfa1ca
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java 2a75b20
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java 706328f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 0662562
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 9ac9f24
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7f1e445
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java 9ea8471
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 1c788a3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java a64bd6d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/RecipeExecLocation.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java be8a631
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java b0ddcf3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java 47b1d19
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java 20864f6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java 552c15e
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java c54789b
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java 728646f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java d11411b
>
> Diff: https://reviews.apache.org/r/39391/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 39391: [FALCON-1546] Add ProcessUpdateTest,
InstanceDependencyTest and other tests and test fixes contributed by Raghav
Gautam and Paul Isaychuk
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39391/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 2:52 p.m.)
Review request for Falcon.
Changes
-------
comments addressed
Bugs: FALCON-1546
https://issues.apache.org/jira/browse/FALCON-1546
Repository: falcon-git
Description
-------
Set of new tests and test fixes
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java b905bee
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 83d06a2
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/EntityLineageUtil.java fc42cf5
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 10463c2
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java 9d028fa
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 5e2c7b2
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 83547e7
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java d956549
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 0fbfc38
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java PRE-CREATION
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java f3a107c
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/LoginPage.java 3193d21
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/MirrorWizardPage.java 6dfa1ca
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java 2a75b20
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java 706328f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 0662562
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 9ac9f24
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7f1e445
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java 9ea8471
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 1c788a3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java a64bd6d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/RecipeExecLocation.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java be8a631
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java b0ddcf3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java 47b1d19
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java 20864f6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java 552c15e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java c54789b
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java 728646f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java d11411b
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/PipelineInstanceDependencyTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/39391/diff/
Testing
-------
Thanks,
Paul Isaychuk
Re: Review Request 39391: [FALCON-1546] Add ProcessUpdateTest,
InstanceDependencyTest and other tests and test fixes contributed by Raghav
Gautam and Paul Isaychuk
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39391/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 12:27 p.m.)
Review request for Falcon.
Bugs: FALCON-1546
https://issues.apache.org/jira/browse/FALCON-1546
Repository: falcon-git
Description
-------
Set of new tests and test fixes
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java b905bee
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 83d06a2
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 10463c2
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java 9d028fa
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 83547e7
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java d956549
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 0fbfc38
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java PRE-CREATION
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java f3a107c
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/LoginPage.java 3193d21
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/MirrorWizardPage.java 6dfa1ca
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java 2a75b20
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java 706328f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 0662562
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 9ac9f24
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7f1e445
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java 9ea8471
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 1c788a3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java a64bd6d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/RecipeExecLocation.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java be8a631
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java b0ddcf3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java 47b1d19
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java 20864f6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java 552c15e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java c54789b
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java 728646f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java d11411b
Diff: https://reviews.apache.org/r/39391/diff/
Testing
-------
Thanks,
Paul Isaychuk
Re: Review Request 39391: [FALCON-1546] Add ProcessUpdateTest,
InstanceDependencyTest and other tests and test fixes contributed by Raghav
Gautam and Paul Isaychuk
Posted by Paul Isaychuk <pi...@hortonworks.com>.
> On Oct. 16, 2015, 11:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java, line 79
> > <https://reviews.apache.org/r/39391/diff/1/?file=1099888#file1099888line79>
> >
> > Can we add this use case as a part of NewPrismProcessUpdateTest.
NewPrismProcessUpdateTest is fully "distributed" test class, so didn't add "embedded" test to it.
> On Oct. 16, 2015, 11:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java, line 286
> > <https://reviews.apache.org/r/39391/diff/1/?file=1099886#file1099886line286>
> >
> > Is it the only case with respect to triage api?
yes
> On Oct. 16, 2015, 11:34 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java, line 68
> > <https://reviews.apache.org/r/39391/diff/1/?file=1099886#file1099886line68>
> >
> > FeedInstanceDependencyTest, ProcessInstanceDependencyTest are already present as part of FALCON-1039. Can we add any missing cases over there if required intead of adding a whole new test.
InstanceDependencyTest launches pipeline scenario of 3 processes and tests dependecy API on this basis which seems a bit different from what FeedInstanceDependencyTest and ProcessInstanceDependencyTest do. May we rename InstanceDependencyTest to something like PipelineInstanceDependencyTest and left it as is to avoid repeating scenario preparation in different classes?
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39391/#review102905
-----------------------------------------------------------
On Oct. 16, 2015, 10:24 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39391/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 10:24 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1546
> https://issues.apache.org/jira/browse/FALCON-1546
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Set of new tests and test fixes
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java ba1d228
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java b905bee
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 83d06a2
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 10463c2
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java 9d028fa
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 83547e7
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java d956549
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 0fbfc38
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java PRE-CREATION
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java f3a107c
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/LoginPage.java 3193d21
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/MirrorWizardPage.java 6dfa1ca
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java 2a75b20
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java 706328f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 0662562
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 9ac9f24
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7f1e445
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java 9ea8471
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 1c788a3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java a64bd6d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/RecipeExecLocation.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java be8a631
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java b0ddcf3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java 47b1d19
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java 20864f6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java 552c15e
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java c54789b
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java 728646f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java d11411b
>
> Diff: https://reviews.apache.org/r/39391/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 39391: [FALCON-1546] Add ProcessUpdateTest,
InstanceDependencyTest and other tests and test fixes contributed by Raghav
Gautam and Paul Isaychuk
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39391/#review102905
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java (line 216)
<https://reviews.apache.org/r/39391/#comment160723>
Is this method required ?
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java (line 557)
<https://reviews.apache.org/r/39391/#comment160719>
getInstanceDependencies method already exists in AbstractEntityHelper
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java (line 564)
<https://reviews.apache.org/r/39391/#comment160724>
Java Doc missing.
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 142)
<https://reviews.apache.org/r/39391/#comment160725>
Java Doc ?
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java (line 45)
<https://reviews.apache.org/r/39391/#comment160726>
Java Doc ?
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java (line 239)
<https://reviews.apache.org/r/39391/#comment160727>
Java Doc
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java (line 30)
<https://reviews.apache.org/r/39391/#comment160728>
Consider adding corresponding JIRA for future reference in java doc.
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java (line 259)
<https://reviews.apache.org/r/39391/#comment160730>
Java Doc missing ?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java (line 68)
<https://reviews.apache.org/r/39391/#comment160720>
FeedInstanceDependencyTest, ProcessInstanceDependencyTest are already present as part of FALCON-1039. Can we add any missing cases over there if required intead of adding a whole new test.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java (line 286)
<https://reviews.apache.org/r/39391/#comment160731>
Is it the only case with respect to triage api?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java (line 79)
<https://reviews.apache.org/r/39391/#comment160722>
Can we add this use case as a part of NewPrismProcessUpdateTest.
- PRAGYA MITTAL
On Oct. 16, 2015, 10:24 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39391/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 10:24 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1546
> https://issues.apache.org/jira/browse/FALCON-1546
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Set of new tests and test fixes
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java ba1d228
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java b905bee
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 83d06a2
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 10463c2
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java 9d028fa
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 83547e7
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java d956549
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 0fbfc38
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java PRE-CREATION
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java f3a107c
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/LoginPage.java 3193d21
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/MirrorWizardPage.java 6dfa1ca
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java 2a75b20
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java 706328f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 0662562
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 9ac9f24
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7f1e445
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java 9ea8471
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 1c788a3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java a64bd6d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/RecipeExecLocation.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java be8a631
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java b0ddcf3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java 47b1d19
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java 20864f6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java 552c15e
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java c54789b
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java 728646f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java d11411b
>
> Diff: https://reviews.apache.org/r/39391/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Paul Isaychuk
>
>