[GitHub] dtrebbien commented on issue #3: NETBEANS-59 - Document split actions

[GitBox <gi...@apache.org>]

dtrebbien commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-357092438
 
 
   Hello @Chris2011,
   
   I believe what @emilianbold meant by having two commits is that the first commit would implement the requested feature while keeping the `SplitDocumentAction` and `ClearSplitAction` nested classes within `org.netbeans.core.multiview.SplitAction`. Presumably you would need to add `SplitDocumentHorizontallyAction` and `SplitDocumentVerticallyAction` nested classes so that you could add the specific `@ActionID`, `@ActionRegistration`, and `@ActionReference` annotations. Then, once you have done this and verified that you are able to invoke the actions via the keyboard shortcuts, the second commit would be a simple refactoring that would move the `ClearSplitAction`, `SplitDocumentAction`, `SplitDocumentHorizontallyAction`, and `SplitDocumentVerticallyAction` nested classes to top-level classes within the `org.netbeans.core.multiview.actions` package.
   
   One subtle issue is that moving message strings LBL_ClearSplitAction, LBL_ValueClearSplit, LBL_SplitDocumentActionHorizontal, LBL_ValueSplitHorizontal, LBL_SplitDocumentActionVertical, LBL_ValueSplitVertical to a different package (from `org.netbeans.core.multiview` to `org.netbeans.core.multiview.actions`) will break existing translations of these strings. For example, there are Czech translations at https://netbeans.org/projects/nblocalization/downloads/directory/8.0.2 which would no longer work. Maybe these message strings could be kept within the `org.netbeans.core.multiview` package and the relocated `ClearSplitAction`, etc. could refer to `org.netbeans.core.multiview.Bundle` for these strings. Or, maybe it's fine to move the strings to the different package. I am not sure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists