You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/04/26 00:33:50 UTC
Review Request 46662: remove TODO OFFHEAP comments
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46662/
-----------------------------------------------------------
Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
Bugs: GEODE-1304
https://issues.apache.org/jira/browse/GEODE-1304
Repository: geode
Description
-------
For the most part just comment changes.
The only non-comment change was in LocalRegion; the validatedCreate/Put/Destroy methods no longer do the release call. The method that calls them now does.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/DummyQRegion.java 35005f9ba475f5f2ae89e8f4d1ae6293e3f9bc4b
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndex.java f8a1b8d4ecba735145bf5aba96e52b080afa9635
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexManager.java a2848102b275b652ba4d1512b3ad6749501487d5
geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java bfbf4491414d1cbd6c5f00e443a12bbaa16138ed
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java debc3da69cffca6789baef2376242deff412e6fb
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e0f043ba332063505df43b4c0d2d731a91e5b266
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java 8b4f240d924bca281d708a893f361fae53e32621
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 575e140da454fc705ff7893c62e2d103f9b4109d
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 063f8231691cf4f64795186dcbe78f7bc90e2c98
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java e3458e7ea5c76d6de81a9aa47c6d49c130786509
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 4360b2a7837844c3b29b8c43a2036656e2183780
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java affddd1ab864239ceccd08ec36320f4fbcc62478
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/OverflowOplog.java 2368b4f1f0872d2fcbc021b775f45a5edc5f85d0
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java 750953a3ff4a209760b17e554440d093a50032d3
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 3fccc9a257139607e6cdfb9fa3433dc2f303c97c
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java a4c60049fe378a647282c901ac4db7490fcc70f9
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java fc9c7ffda14f38c22b824bd6921feef5b56cc366
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskLRURegionEntryHeap.java dfbc88001c2b475f4a253e8604a7a59e495d93bd
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskLRURegionEntryOffHeap.java 8ddab6c91335f97e03f5eab3eedc43281dbf464f
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskRegionEntryHeap.java 517d594674d26b7e83e9cc88f94ef27b15ce3889
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskRegionEntryOffHeap.java 260ef09e561e24a8579bd89f37654dbb7fd71713
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsLRURegionEntryHeap.java 41c9982c9132e4a8274bd2c92f52bbe7816f5716
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsLRURegionEntryOffHeap.java 555be1b1407a1f3f08cf407a6f4433c52385d2c4
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsRegionEntryHeap.java 1f68a4b2ecb2c46273bff777926398a321d7f83e
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsRegionEntryOffHeap.java cf97a05d079b05cad1a63df32a7c29857394193e
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskLRURegionEntryHeap.java fc5325788172e23c48618b8f4742f4f6231370f2
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskLRURegionEntryOffHeap.java a9f1399234b9e1f53d13b4f41017f325d8862b8e
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskRegionEntryHeap.java 4161f117f055e5b919d78d7cac86d3550b0f78b2
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskRegionEntryOffHeap.java 5b7d65426772e32fcbc3456c8644d865d380e5b0
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinLRURegionEntryHeap.java a7f06475be2f9d48ef89ac69cfef2786f1ada5ed
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinLRURegionEntryOffHeap.java b2d2b8207e9034689d8819c1350ed6be286090cf
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinRegionEntryHeap.java d17d3fd75be6f5c291fe5529c026a64e9af1731b
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinRegionEntryOffHeap.java c752156f424125eda22bc7262bfc7870167bc983
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskLRURegionEntryHeap.java 51ab750e8154d2ff06c1005171a8489694335676
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskLRURegionEntryOffHeap.java 1515fe9f38ba7813f07636d6956732928d167fb0
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskRegionEntryHeap.java 158aeee773f60fc663a48346f3dce4367580d1d7
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskRegionEntryOffHeap.java 2291f86213d52cfddcb25354e3705f3082dbbd78
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsLRURegionEntryHeap.java d3f1b00d03ec76c1b728fa10068e2a9d518b7d95
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsLRURegionEntryOffHeap.java b12d8dd217c01e216256a30cb483676684ffe538
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsRegionEntryHeap.java e6a1bf0aa5fae08905089a72b45e172f40dad63f
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsRegionEntryOffHeap.java eb4ac39161d12f4d148a07f2cfa9e96ae30637be
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskLRURegionEntryHeap.java dedbfc0272b9bb3ae3ab17462a3fdc10176cd158
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskLRURegionEntryOffHeap.java 43cec013704fab07ee6e3c15173b6e9a49f0d1d0
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskRegionEntryHeap.java 2c15b68ef5a09c628eb3d5a276b332536c616868
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskRegionEntryOffHeap.java ebd3dc5a5a7bdb18844c562ee8686e08e84fba9a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinLRURegionEntryHeap.java aaa592980c6852f0c5c03d36d89b22bbcfc79661
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinLRURegionEntryOffHeap.java 47515ad784242d68a544c046bdff1acfde573b21
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinRegionEntryHeap.java e43ce405617ea45a9e91ea658346176a8f3d0a2a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinRegionEntryOffHeap.java 29db90021c420b3607db900a492591c70ae2749f
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/InternalResourceManager.java 96d2b87c579b6e0f01ade337a92679388d7df041
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java 3a6f04e4a8412b7a478e6b7d33cccebcef615abd
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java db11a8e48590c886f9dd9bcdc141ffd7d9711218
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommand.java c264616c332e3626ebd10a38de0d0a2b39b77319
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java 94b4953a76f289e9a05d2e5224fb604b25268acd
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Destroy65.java 1da422a611e66883f50fe27683ed66b257b4b10a
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Get70.java b2be3c3a7c6f27e4a53489e6cd3eea7fb3fbc6cc
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Request.java b40b6e5900f5c38431577889030250c275553d1e
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java abbea4513e10d0606f4fd580e5bafb273b75eac8
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java b4efd213414f6ce2bcb56b866442c7e9fe8378e3
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/AbstractStoredObject.java 22e2d55ec2af2bf742a7d1bf72bddebfad8920cb
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java 6de7be940f579a81f73e5663b5e645e1ab475508
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObject.java 9861a54042b7eb5134a7b7c4b272131b9ce6dd0b
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/TinyStoredObject.java e8878fa9b29a82039ae14ef7b507a33bdf911ffe
geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/MsgStreamer.java 9fb2eb8d99749243f099c520a8dc3cd739e40b11
geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxReaderImpl.java f4b133c299d7adfb861db62d3356b3c8ef08efc0
geode-core/src/test/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImplJUnitTest.java 8efec6e40381dc528940f076c9bb3e99bdc41faf
geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqServiceImpl.java 05e062c35621160c16db754409be02e2d4a53a31
Diff: https://reviews.apache.org/r/46662/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 46662: remove TODO OFFHEAP comments
Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46662/#review130521
-----------------------------------------------------------
Ship it!
Ship It!
- Sai Boorlagadda
On April 25, 2016, 10:33 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46662/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 10:33 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1304
> https://issues.apache.org/jira/browse/GEODE-1304
>
>
> Repository: geode
>
>
> Description
> -------
>
> For the most part just comment changes.
> The only non-comment change was in LocalRegion; the validatedCreate/Put/Destroy methods no longer do the release call. The method that calls them now does.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/DummyQRegion.java 35005f9ba475f5f2ae89e8f4d1ae6293e3f9bc4b
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndex.java f8a1b8d4ecba735145bf5aba96e52b080afa9635
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexManager.java a2848102b275b652ba4d1512b3ad6749501487d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java bfbf4491414d1cbd6c5f00e443a12bbaa16138ed
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java debc3da69cffca6789baef2376242deff412e6fb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e0f043ba332063505df43b4c0d2d731a91e5b266
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java 8b4f240d924bca281d708a893f361fae53e32621
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 575e140da454fc705ff7893c62e2d103f9b4109d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 063f8231691cf4f64795186dcbe78f7bc90e2c98
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java e3458e7ea5c76d6de81a9aa47c6d49c130786509
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 4360b2a7837844c3b29b8c43a2036656e2183780
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java affddd1ab864239ceccd08ec36320f4fbcc62478
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/OverflowOplog.java 2368b4f1f0872d2fcbc021b775f45a5edc5f85d0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java 750953a3ff4a209760b17e554440d093a50032d3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 3fccc9a257139607e6cdfb9fa3433dc2f303c97c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java a4c60049fe378a647282c901ac4db7490fcc70f9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java fc9c7ffda14f38c22b824bd6921feef5b56cc366
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskLRURegionEntryHeap.java dfbc88001c2b475f4a253e8604a7a59e495d93bd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskLRURegionEntryOffHeap.java 8ddab6c91335f97e03f5eab3eedc43281dbf464f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskRegionEntryHeap.java 517d594674d26b7e83e9cc88f94ef27b15ce3889
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskRegionEntryOffHeap.java 260ef09e561e24a8579bd89f37654dbb7fd71713
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsLRURegionEntryHeap.java 41c9982c9132e4a8274bd2c92f52bbe7816f5716
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsLRURegionEntryOffHeap.java 555be1b1407a1f3f08cf407a6f4433c52385d2c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsRegionEntryHeap.java 1f68a4b2ecb2c46273bff777926398a321d7f83e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsRegionEntryOffHeap.java cf97a05d079b05cad1a63df32a7c29857394193e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskLRURegionEntryHeap.java fc5325788172e23c48618b8f4742f4f6231370f2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskLRURegionEntryOffHeap.java a9f1399234b9e1f53d13b4f41017f325d8862b8e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskRegionEntryHeap.java 4161f117f055e5b919d78d7cac86d3550b0f78b2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskRegionEntryOffHeap.java 5b7d65426772e32fcbc3456c8644d865d380e5b0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinLRURegionEntryHeap.java a7f06475be2f9d48ef89ac69cfef2786f1ada5ed
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinLRURegionEntryOffHeap.java b2d2b8207e9034689d8819c1350ed6be286090cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinRegionEntryHeap.java d17d3fd75be6f5c291fe5529c026a64e9af1731b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinRegionEntryOffHeap.java c752156f424125eda22bc7262bfc7870167bc983
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskLRURegionEntryHeap.java 51ab750e8154d2ff06c1005171a8489694335676
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskLRURegionEntryOffHeap.java 1515fe9f38ba7813f07636d6956732928d167fb0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskRegionEntryHeap.java 158aeee773f60fc663a48346f3dce4367580d1d7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskRegionEntryOffHeap.java 2291f86213d52cfddcb25354e3705f3082dbbd78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsLRURegionEntryHeap.java d3f1b00d03ec76c1b728fa10068e2a9d518b7d95
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsLRURegionEntryOffHeap.java b12d8dd217c01e216256a30cb483676684ffe538
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsRegionEntryHeap.java e6a1bf0aa5fae08905089a72b45e172f40dad63f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsRegionEntryOffHeap.java eb4ac39161d12f4d148a07f2cfa9e96ae30637be
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskLRURegionEntryHeap.java dedbfc0272b9bb3ae3ab17462a3fdc10176cd158
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskLRURegionEntryOffHeap.java 43cec013704fab07ee6e3c15173b6e9a49f0d1d0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskRegionEntryHeap.java 2c15b68ef5a09c628eb3d5a276b332536c616868
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskRegionEntryOffHeap.java ebd3dc5a5a7bdb18844c562ee8686e08e84fba9a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinLRURegionEntryHeap.java aaa592980c6852f0c5c03d36d89b22bbcfc79661
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinLRURegionEntryOffHeap.java 47515ad784242d68a544c046bdff1acfde573b21
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinRegionEntryHeap.java e43ce405617ea45a9e91ea658346176a8f3d0a2a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinRegionEntryOffHeap.java 29db90021c420b3607db900a492591c70ae2749f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/InternalResourceManager.java 96d2b87c579b6e0f01ade337a92679388d7df041
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java 3a6f04e4a8412b7a478e6b7d33cccebcef615abd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java db11a8e48590c886f9dd9bcdc141ffd7d9711218
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommand.java c264616c332e3626ebd10a38de0d0a2b39b77319
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java 94b4953a76f289e9a05d2e5224fb604b25268acd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Destroy65.java 1da422a611e66883f50fe27683ed66b257b4b10a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Get70.java b2be3c3a7c6f27e4a53489e6cd3eea7fb3fbc6cc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Request.java b40b6e5900f5c38431577889030250c275553d1e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java abbea4513e10d0606f4fd580e5bafb273b75eac8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java b4efd213414f6ce2bcb56b866442c7e9fe8378e3
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/AbstractStoredObject.java 22e2d55ec2af2bf742a7d1bf72bddebfad8920cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java 6de7be940f579a81f73e5663b5e645e1ab475508
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObject.java 9861a54042b7eb5134a7b7c4b272131b9ce6dd0b
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/TinyStoredObject.java e8878fa9b29a82039ae14ef7b507a33bdf911ffe
> geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/MsgStreamer.java 9fb2eb8d99749243f099c520a8dc3cd739e40b11
> geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxReaderImpl.java f4b133c299d7adfb861db62d3356b3c8ef08efc0
> geode-core/src/test/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImplJUnitTest.java 8efec6e40381dc528940f076c9bb3e99bdc41faf
> geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqServiceImpl.java 05e062c35621160c16db754409be02e2d4a53a31
>
> Diff: https://reviews.apache.org/r/46662/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 46662: remove TODO OFFHEAP comments
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46662/#review130522
-----------------------------------------------------------
Fix it, then Ship it!
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java (line 1421)
<https://reviews.apache.org/r/46662/#comment194291>
Fix comment, should be "see"
- Ken Howe
On April 25, 2016, 10:33 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46662/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 10:33 p.m.)
>
>
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
>
>
> Bugs: GEODE-1304
> https://issues.apache.org/jira/browse/GEODE-1304
>
>
> Repository: geode
>
>
> Description
> -------
>
> For the most part just comment changes.
> The only non-comment change was in LocalRegion; the validatedCreate/Put/Destroy methods no longer do the release call. The method that calls them now does.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/DummyQRegion.java 35005f9ba475f5f2ae89e8f4d1ae6293e3f9bc4b
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/HashIndex.java f8a1b8d4ecba735145bf5aba96e52b080afa9635
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexManager.java a2848102b275b652ba4d1512b3ad6749501487d5
> geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java bfbf4491414d1cbd6c5f00e443a12bbaa16138ed
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java debc3da69cffca6789baef2376242deff412e6fb
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e0f043ba332063505df43b4c0d2d731a91e5b266
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java 8b4f240d924bca281d708a893f361fae53e32621
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 575e140da454fc705ff7893c62e2d103f9b4109d
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java 063f8231691cf4f64795186dcbe78f7bc90e2c98
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java e3458e7ea5c76d6de81a9aa47c6d49c130786509
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 4360b2a7837844c3b29b8c43a2036656e2183780
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Oplog.java affddd1ab864239ceccd08ec36320f4fbcc62478
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/OverflowOplog.java 2368b4f1f0872d2fcbc021b775f45a5edc5f85d0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java 750953a3ff4a209760b17e554440d093a50032d3
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java 3fccc9a257139607e6cdfb9fa3433dc2f303c97c
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEntryState.java a4c60049fe378a647282c901ac4db7490fcc70f9
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/UpdateOperation.java fc9c7ffda14f38c22b824bd6921feef5b56cc366
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskLRURegionEntryHeap.java dfbc88001c2b475f4a253e8604a7a59e495d93bd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskLRURegionEntryOffHeap.java 8ddab6c91335f97e03f5eab3eedc43281dbf464f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskRegionEntryHeap.java 517d594674d26b7e83e9cc88f94ef27b15ce3889
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsDiskRegionEntryOffHeap.java 260ef09e561e24a8579bd89f37654dbb7fd71713
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsLRURegionEntryHeap.java 41c9982c9132e4a8274bd2c92f52bbe7816f5716
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsLRURegionEntryOffHeap.java 555be1b1407a1f3f08cf407a6f4433c52385d2c4
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsRegionEntryHeap.java 1f68a4b2ecb2c46273bff777926398a321d7f83e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMStatsRegionEntryOffHeap.java cf97a05d079b05cad1a63df32a7c29857394193e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskLRURegionEntryHeap.java fc5325788172e23c48618b8f4742f4f6231370f2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskLRURegionEntryOffHeap.java a9f1399234b9e1f53d13b4f41017f325d8862b8e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskRegionEntryHeap.java 4161f117f055e5b919d78d7cac86d3550b0f78b2
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinDiskRegionEntryOffHeap.java 5b7d65426772e32fcbc3456c8644d865d380e5b0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinLRURegionEntryHeap.java a7f06475be2f9d48ef89ac69cfef2786f1ada5ed
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinLRURegionEntryOffHeap.java b2d2b8207e9034689d8819c1350ed6be286090cf
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinRegionEntryHeap.java d17d3fd75be6f5c291fe5529c026a64e9af1731b
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VMThinRegionEntryOffHeap.java c752156f424125eda22bc7262bfc7870167bc983
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskLRURegionEntryHeap.java 51ab750e8154d2ff06c1005171a8489694335676
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskLRURegionEntryOffHeap.java 1515fe9f38ba7813f07636d6956732928d167fb0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskRegionEntryHeap.java 158aeee773f60fc663a48346f3dce4367580d1d7
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsDiskRegionEntryOffHeap.java 2291f86213d52cfddcb25354e3705f3082dbbd78
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsLRURegionEntryHeap.java d3f1b00d03ec76c1b728fa10068e2a9d518b7d95
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsLRURegionEntryOffHeap.java b12d8dd217c01e216256a30cb483676684ffe538
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsRegionEntryHeap.java e6a1bf0aa5fae08905089a72b45e172f40dad63f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedStatsRegionEntryOffHeap.java eb4ac39161d12f4d148a07f2cfa9e96ae30637be
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskLRURegionEntryHeap.java dedbfc0272b9bb3ae3ab17462a3fdc10176cd158
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskLRURegionEntryOffHeap.java 43cec013704fab07ee6e3c15173b6e9a49f0d1d0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskRegionEntryHeap.java 2c15b68ef5a09c628eb3d5a276b332536c616868
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinDiskRegionEntryOffHeap.java ebd3dc5a5a7bdb18844c562ee8686e08e84fba9a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinLRURegionEntryHeap.java aaa592980c6852f0c5c03d36d89b22bbcfc79661
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinLRURegionEntryOffHeap.java 47515ad784242d68a544c046bdff1acfde573b21
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinRegionEntryHeap.java e43ce405617ea45a9e91ea658346176a8f3d0a2a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/VersionedThinRegionEntryOffHeap.java 29db90021c420b3607db900a492591c70ae2749f
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/InternalResourceManager.java 96d2b87c579b6e0f01ade337a92679388d7df041
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/DestroyMessage.java 3a6f04e4a8412b7a478e6b7d33cccebcef615abd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java db11a8e48590c886f9dd9bcdc141ffd7d9711218
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommand.java c264616c332e3626ebd10a38de0d0a2b39b77319
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java 94b4953a76f289e9a05d2e5224fb604b25268acd
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Destroy65.java 1da422a611e66883f50fe27683ed66b257b4b10a
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Get70.java b2be3c3a7c6f27e4a53489e6cd3eea7fb3fbc6cc
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/Request.java b40b6e5900f5c38431577889030250c275553d1e
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventImpl.java abbea4513e10d0606f4fd580e5bafb273b75eac8
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java b4efd213414f6ce2bcb56b866442c7e9fe8378e3
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/AbstractStoredObject.java 22e2d55ec2af2bf742a7d1bf72bddebfad8920cb
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java 6de7be940f579a81f73e5663b5e645e1ab475508
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObject.java 9861a54042b7eb5134a7b7c4b272131b9ce6dd0b
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/TinyStoredObject.java e8878fa9b29a82039ae14ef7b507a33bdf911ffe
> geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/MsgStreamer.java 9fb2eb8d99749243f099c520a8dc3cd739e40b11
> geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxReaderImpl.java f4b133c299d7adfb861db62d3356b3c8ef08efc0
> geode-core/src/test/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImplJUnitTest.java 8efec6e40381dc528940f076c9bb3e99bdc41faf
> geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqServiceImpl.java 05e062c35621160c16db754409be02e2d4a53a31
>
> Diff: https://reviews.apache.org/r/46662/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>