[jira] [Comment Edited] (OFBIZ-5057) Image rendering issue on productdetail.ftl

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480956#comment-13480956 ] 

Jacques Le Roux edited comment on OFBIZ-5057 at 10/22/12 6:39 AM:
------------------------------------------------------------------

Ha, I'm surprised, from the [definition of has_content|http://freemarker.sourceforge.net/docs/ref_builtins_expert.html#ref_builtin_has_content] it should be sufficient:
<<It is true if the variable exists (and isn't Java null) and is not ``empty'', otherwise it is false>>

Have you an use case?
                
      was (Author: jacques.le.roux):
    Ha, I'm surprised, from the [definition of has_content|freemarker.sourceforge.net/docs/ref_builtins_expert.html#ref_builtin_has_content] it should be sufficient:
<<It is true if the variable exists (and isn't Java null) and is not ``empty'', otherwise it is false>>

Have you an use case?
                  
> Image rendering issue on productdetail.ftl
> ------------------------------------------
>
>                 Key: OFBIZ-5057
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5057
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: FTL code, not relevant
>            Reporter: Carsten Schinzer
>            Priority: Minor
>             Fix For: SVN trunk
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Reference: Line 358
> !     <#if productImageList?has_content>
> A validation seems to have been introduced by rev. 1345532 where before on the FTL if clause, both checks (not null and hs content) were executed while now they are no longer. This leads to a failure to render of no related Content Images are on the Product but only attributed image URLs.
> 1     <#if productImageList?if_exists && productImageList?has_content>
> Does the trick, so would the earlier version:
> 2     <#if productImageList != null && productImageList?has_content>
> I also assume that with rev. 1345532 it was intended to put this here:
> 3     <#if productImageList?? && productImageList?has_content>
>  I leave it to the FTL pros to comment and recommend for ca. 24 hours.
>  If no comment by tomorrow, I shall propose to use the former code corresponding to [3] as this is what was the latest agreement made on OFBIZ-4916.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira