[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7348: Suppress stack trace when deserializing task payload fails

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #7348: Suppress stack trace when deserializing task payload fails
URL: https://github.com/apache/incubator-druid/pull/7348#discussion_r269346605
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataStorageActionHandler.java
 ##########
 @@ -357,7 +357,7 @@ private String getWhereClauseForActiveStatusesQuery(String dataSource)
         task = objectMapper.readValue(resultSet.getBytes("payload"), entryType);
       }
       catch (IOException e) {
-        log.error(e, "Encountered exception while deserializing task payload, setting task to null");
+        log.warn("Encountered exception[%s] while deserializing task payload, setting payload to null", e.getMessage());
 
 Review comment:
   Hmm, I'm not sure what the best term is here. If `task` is set to null, all fields of a complete task entry in the overlord UI would be filled with nulls. People might look at the logs why they're nulls and will see this log. But then, `Setting task to null` is not very intuitive because they will be probably not familiar with internal code of Druid. I used `payload` because it's the column name of metadata store table. Would it be more clear if it says `Encountered exception[%s] while deserializing task payload from the metadata store, setting payload to null`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org