[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1031: IGNITE-17338 Implement RocksDB hash index storage

[GitBox <gi...@apache.org>]

ibessonov commented on code in PR #1031:
URL: https://github.com/apache/ignite-3/pull/1031#discussion_r952326547


##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -98,9 +101,15 @@ class RocksDbTableStorage implements MvTableStorage {
     /** Column Family handle for partition data. */
     private volatile ColumnFamily partitionCf;
 
+    /** Column Family handle for Hash Index data. */
+    private volatile ColumnFamily hashIndexCf;
+
     /** Partition storages. */
     private volatile AtomicReferenceArray<RocksDbMvPartitionStorage> partitions;
 
+    /** Hash Index storages by their names. */
+    private final ConcurrentMap<String, HashIndexStorage> hashIndices = new ConcurrentHashMap<>();

Review Comment:
   Storing indexed by ids would be more appropriate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org