You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by gtapper <gi...@git.apache.org> on 2016/03/18 00:38:20 UTC
[GitHub] incubator-trafodion pull request: Trafodion 1894 & 1898
GitHub user gtapper opened a pull request:
https://github.com/apache/incubator-trafodion/pull/392
Trafodion 1894 & 1898
Fixes ready for delivery.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gtapper/incubator-trafodion TRAFODION-1898
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/392.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #392
----
commit 2f31eecbbe92821489f4164c7b21c9f3d9839311
Author: Gunnar Tapper <gt...@esgyn.local>
Date: 2016-03-17T07:27:55Z
Backup checkin.
commit c42077441dce5f41f438cdeb782c6dfecdd7fce2
Author: Gunnar Tapper <gt...@esgyn.local>
Date: 2016-03-17T23:27:39Z
Fixes for TRAFODION-1898 and TRAFODION-1894.
The Client Install guide has been updated to support Windows 10. In
addition, the content has been tested and changed accordingly. Finally, I
added a blurb about how to handle the fact that the WinODBC driver is not
part of the download package. (TRAFODION-1898)
The Command Interface guide was updated to used the correct default port
number (23400) and to allow code examples to be downloaded.
The documentation page was updated to link to select wiki pages for UDF
and manageability.
The download page was updated to clarify the content of the Client
download package. (TRAFODION-1894).
Please rebuild the 1.3.0 and 2.0.0 documentation. Once done, please
refresh the Trafodion web site.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Trafodion 1894 & 1898
Posted by gtapper <gi...@git.apache.org>.
Github user gtapper commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/392#discussion_r56598119
--- Diff: docs/client_install/src/asciidoc/_chapters/dbviz.adoc ---
@@ -69,14 +66,16 @@ image:{images}/DbVisualizer_Driver_Manager.jpg[image]
* Use the JDBC URL format:
+
```
-jdbc:t4jdbc://<host-name or ip-address>:37800/:
+jdbc:t4jdbc://<host-name or ip-address>:23400/:
```
++
+*NOTE*: This example uses a modified port number (*37800*) rather than the default port number (*23400*).
--- End diff --
You're not seeing the screenshot. :) It contains the 37800 value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Trafodion 1894 & 1898
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/392
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Trafodion 1894 & 1898
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/392#discussion_r56595960
--- Diff: docs/client_install/src/asciidoc/_chapters/dbviz.adoc ---
@@ -69,14 +66,16 @@ image:{images}/DbVisualizer_Driver_Manager.jpg[image]
* Use the JDBC URL format:
+
```
-jdbc:t4jdbc://<host-name or ip-address>:37800/:
+jdbc:t4jdbc://<host-name or ip-address>:23400/:
```
++
+*NOTE*: This example uses a modified port number (*37800*) rather than the default port number (*23400*).
--- End diff --
I don't get it. The example uses 23400, and then the *NOTE* says we aren't using 23400.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Trafodion 1894 & 1898
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/392#discussion_r56596268
--- Diff: docs/client_install/src/asciidoc/_chapters/jdbct4.adoc ---
@@ -117,16 +80,42 @@ go to this link: http://www.java.com/en/download
After installing the Java version, proceed with setting the Java path. Follow one of these sets of instructions, depending on the operating
system of your client workstation:
-* <<jdbct4_path_windows, Setting the PATH to a Supported Java Version on Windows>>
-* <<jdbct4_path_linux, Setting the PATH to a Supported Java Version on Linux>>
+* <<jdbct4-path-windows, Setting the PATH to a Supported Java Version on Windows>>
+* <<jdbct4-path-linux, Setting the PATH to a Supported Java Version on Linux>>
-[[jdbct4_path_windows]]
+[[jdbct4-path-windows]]
==== Set Windows PATH Variable
-1. Right-click the *Computer* icon on your desktop, and then select *Properties*. The *Control Panel > System and Security > System* window
+===== Windows 10
+
+1. Right-clock on the Windows icon on the menu bar. Select *System*.
--- End diff --
Typo, should be "Right-click". (Though "Right-clock" sounds more interesting.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---