[GitHub] [arrow] westonpace commented on pull request #12601: ARROW-15901: [C++] Support Substrait projection with custom output field names

[GitBox <gi...@apache.org>]

westonpace commented on PR #12601:
URL: https://github.com/apache/arrow/pull/12601#issuecomment-1116637990

   The Arrow-Substrait code is definitely in flex.  Nothing has been released externally via any binidings so I wouldn't worry about any backwards incompatible changes.
   
   That being said, I think `SinkNodeConsumer` has an `Init` method which receives a schema.  This is called by `ConsumingSinkNode` in `ConsumingSinkNode::StartProducing`.  At that point (`StartProducing`) the `ConsumingSinkNode` should have access to the schema (it's the output schema of the node's single input).
   
   Instead of passing that schema directly it should modify the schema with the names that it gets from its options.  So the act of assigning names to an existing schema would happen in `ConsumingSinkNode::StartProducing`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org