You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/05/18 11:55:44 UTC
[GitHub] [hadoop-ozone] fapifta opened a new pull request #937: HDDS-3607. Lot of warnings at DN startup.
fapifta opened a new pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937
## What changes were proposed in this pull request?
The log message which is at WARN level before the PR, is printed for every edit in the raft log during DataNode startup, we don't need to spam with this many warnings, especially as this is part of normal operations. The proposal is to change it to DEBUG level.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3607
## How was this patch tested?
No tests were done, seems to be too trivial to be wrong :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #937: HDDS-3607. Lot of warnings at DN startup.
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937#issuecomment-634878292
@fapifta Thanks for working on this!
@sodonnel @mukul1987 Thanks for the reviews!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel merged pull request #937: HDDS-3607. Lot of warnings at DN startup.
Posted by GitBox <gi...@apache.org>.
vivekratnavel merged pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] fapifta commented on pull request #937: HDDS-3607. Lot of warnings at DN startup.
Posted by GitBox <gi...@apache.org>.
fapifta commented on pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937#issuecomment-630181617
Hmm... there were an integration test failure that was not related (usual timeout we see in integration tests), I am unsure how to re-initiate testing, but it does not seem to work... :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #937: HDDS-3607. Lot of warnings at DN startup.
Posted by GitBox <gi...@apache.org>.
fapifta commented on a change in pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937#discussion_r428081888
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java
##########
@@ -108,9 +108,11 @@ public long putBlock(Container container, BlockData data) throws IOException {
// transaction is reapplied in the ContainerStateMachine on restart.
// It also implies that the given block must already exist in the db.
// just log and return
- LOG.warn("blockCommitSequenceId {} in the Container Db is greater than"
- + " the supplied value {}. Ignoring it",
- containerBCSId, bcsId);
+ if (LOG.isDebugEnabled()) {
Review comment:
yepp, you are right, muscle memory I guess :D Thank you for checking it, I pushed a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] fapifta commented on pull request #937: HDDS-3607. Lot of warnings at DN startup.
Posted by GitBox <gi...@apache.org>.
fapifta commented on pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937#issuecomment-634593065
/retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] fapifta commented on pull request #937: HDDS-3607. Lot of warnings at DN startup.
Posted by GitBox <gi...@apache.org>.
fapifta commented on pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937#issuecomment-630179610
/retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel commented on a change in pull request #937: HDDS-3607. Lot of warnings at DN startup.
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937#discussion_r426732321
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java
##########
@@ -108,9 +108,11 @@ public long putBlock(Container container, BlockData data) throws IOException {
// transaction is reapplied in the ContainerStateMachine on restart.
// It also implies that the given block must already exist in the db.
// just log and return
- LOG.warn("blockCommitSequenceId {} in the Container Db is greater than"
- + " the supplied value {}. Ignoring it",
- containerBCSId, bcsId);
+ if (LOG.isDebugEnabled()) {
Review comment:
http://www.slf4j.org/faq.html#logging_performance suggests the IF wrapper is not needed for performance reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] fapifta commented on pull request #937: HDDS-3607. Lot of warnings at DN startup.
Posted by GitBox <gi...@apache.org>.
fapifta commented on pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937#issuecomment-630166960
/retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sodonnel commented on a change in pull request #937: HDDS-3607. Lot of warnings at DN startup.
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937#discussion_r426717257
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java
##########
@@ -108,9 +108,11 @@ public long putBlock(Container container, BlockData data) throws IOException {
// transaction is reapplied in the ContainerStateMachine on restart.
// It also implies that the given block must already exist in the db.
// just log and return
- LOG.warn("blockCommitSequenceId {} in the Container Db is greater than"
- + " the supplied value {}. Ignoring it",
- containerBCSId, bcsId);
+ if (LOG.isDebugEnabled()) {
Review comment:
Is it necessary to wrap a debug log entry in the `if (LOG.isDebugEnabled())` statement? It is my understanding, that so long as you are not doing string interpolation in the log message and are passing simple variables as any parameters to the log message (ie not doing any computation to calculate the values being passed), then LOG4J does the correct thing and there is no performance penalty to removing the IF wrapper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org