You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Qian Zhang (JIRA)" <ji...@apache.org> on 2019/04/15 13:33:00 UTC

[jira] [Commented] (MESOS-9685) Backport docker manifest v2s2 support to 1.4.x

    [ https://issues.apache.org/jira/browse/MESOS-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817971#comment-16817971 ] 

Qian Zhang commented on MESOS-9685:
-----------------------------------

Backported to 1.4.x:
commit cb492ccdc949a5b2be07f41c42f9db1186596ed8
Author: Gilbert Song <so...@gmail.com>
Date:   Fri Apr 12 17:13:58 2019 +0800

    Fixed the URI fetcher image fetch test failure on windows.
    
    Review: https://reviews.apache.org/r/70398/

 src/tests/uri_fetcher_tests.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

commit 1b6568f150013ab5def600cd1047017b5855d431
Author: Andrei Budnik <ab...@mesosphere.com>
Date:   Fri Apr 5 13:06:49 2019 +0200

    Fixed use-after-free bug in Docker provisioner store.
    
    Deferred lambda callback of the `moveLayers()` to the `StoreProcess`
    to prevent use-after-free of the process object since the callback
    refers to the `StoreProcess` class variable `flags`.
    
    Review: https://reviews.apache.org/r/70405

 src/slave/containerizer/mesos/provisioner/docker/store.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

commit df4babfdd718bb9325eb6c1bac9b2995cffacc8e
Author: Gilbert Song <so...@gmail.com>
Date:   Wed Mar 27 17:33:19 2019 -0700

    Added a unit test for Mesos containerizer image force pulling.
    
    Review: https://reviews.apache.org/r/70366

 src/tests/containerizer/provisioner_docker_tests.cpp | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 115 insertions(+)

commit 71ba7a8a0da085f8b9b81ca5f9951b50fc328164
Author: Gilbert Song <so...@gmail.com>
Date:   Fri Mar 22 10:37:46 2019 -0700

    Added gcr registry test.
    
    Review: https://reviews.apache.org/r/70291

 src/tests/containerizer/provisioner_docker_tests.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

commit 29c2663f7ae365bae005dd0c31d22d26422de9ef
Author: Gilbert Song <so...@gmail.com>
Date:   Wed Mar 27 12:03:00 2019 -0700

    Fixed docker fetcher plugin unit test for v2s2 change.
    
    Review: https://reviews.apache.org/r/70290

 src/tests/uri_fetcher_tests.cpp | 60 ++++++++++++++++++++++++++----------------------------------
 1 file changed, 26 insertions(+), 34 deletions(-)

commit 46b1a62b4d3838d54d5d9ecba3ed76eb9b2bddda
Author: Gilbert Song <so...@gmail.com>
Date:   Sat Mar 23 21:14:15 2019 -0700

    Added a TODO for additional URLs support.
    
    Review: https://reviews.apache.org/r/70289

 src/uri/fetchers/docker.cpp | 2 ++
 1 file changed, 2 insertions(+)

commit bc233896d69a4af772463355fc9e53c999b366c0
Author: Gilbert Song <so...@gmail.com>
Date:   Fri Mar 22 00:32:30 2019 -0700

    Supported docker manifest v2 schema2.
    
    Review: https://reviews.apache.org/r/70288

 src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp | 266 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------
 src/slave/containerizer/mesos/provisioner/docker/store.cpp           |  56 ++++++++++++++++---
 src/uri/fetchers/docker.cpp                                          | 296 ++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------
 3 files changed, 396 insertions(+), 222 deletions(-)

commit 7e2e044694a69017e28c961a90b9f65e3dc59653
Author: Gilbert Song <so...@gmail.com>
Date:   Mon Apr 1 22:42:53 2019 -0700

    Added protobuf for docker v2 schema2 config_digest in 'Image'.
    
    Review: https://reviews.apache.org/r/70365

 src/slave/containerizer/mesos/provisioner/docker/message.proto | 4 ++++
 1 file changed, 4 insertions(+)

commit 0161d5decf2df4f1fa12f63dfb31cf8e69a4aac9
Author: Gilbert Song <so...@gmail.com>
Date:   Mon Apr 1 16:11:43 2019 -0700

    Refactored the UCR docker store to construct 'Image' proto at pullers.
    
    This refactoring is needed for supporting docker manifest v2s2 because
    the puller has to let the docker store knows the v1 config, and this
    is also needed for garbage collecting the v1 config in the image layer
    store.
    
    Review: https://reviews.apache.org/r/70354

 src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp     | 20 ++++++++++++++------
 src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp     |  2 +-
 src/slave/containerizer/mesos/provisioner/docker/message.proto        |  4 +++-
 src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp | 28 +++++++---------------------
 src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp | 12 ++----------
 src/slave/containerizer/mesos/provisioner/docker/puller.hpp           |  4 +++-
 src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp  | 28 +++++++++++++++++-----------
 src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp  |  2 +-
 src/slave/containerizer/mesos/provisioner/docker/store.cpp            | 16 ++++++++--------
 src/tests/containerizer/provisioner_docker_tests.cpp                  | 20 ++++++++++++++------
 10 files changed, 70 insertions(+), 66 deletions(-)

commit a366022dbe3278854f12dd295e9158f4f89c31e5
Author: Gilbert Song <so...@gmail.com>
Date:   Sat Mar 23 20:54:08 2019 -0700

    Added 'prettyjws' option to docker manifest V2 Schema1 accept header.
    
    Review: https://reviews.apache.org/r/70287

 src/uri/fetchers/docker.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

> Backport docker manifest v2s2 support to 1.4.x
> ----------------------------------------------
>
>                 Key: MESOS-9685
>                 URL: https://issues.apache.org/jira/browse/MESOS-9685
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Gilbert Song
>            Assignee: Qian Zhang
>            Priority: Major
>              Labels: containerization
>             Fix For: 1.4.4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)