You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "phongn (via GitHub)" <gi...@apache.org> on 2023/11/16 22:40:25 UTC

[PR] Remove HAVE_FLOAT_H build var [trafficserver]

phongn opened a new pull request, #10803:
URL: https://github.com/apache/trafficserver/pull/10803

   Replace automake-style `HAVE_INCLUDE_H` compile flags with `#if __has_include` preprocessor directives.
   
   This PR does so for `float.h` (which should always exist as a standard header, and thus all guards are removed). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove HAVE_FLOAT_H build var [trafficserver]

Posted by "phongn (via GitHub)" <gi...@apache.org>.
phongn commented on PR #10803:
URL: https://github.com/apache/trafficserver/pull/10803#issuecomment-1815743583

   > Can you try to just remove including float.h? I don't think its necessary
   
   `src/iocore/cache/HttpTransactCache.cc` and `src/records/RecUtils.cc` rely on `float.h` via `include/tscore/ink_platform.h`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove HAVE_FLOAT_H build var [trafficserver]

Posted by "dragon512 (via GitHub)" <gi...@apache.org>.
dragon512 merged PR #10803:
URL: https://github.com/apache/trafficserver/pull/10803


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org