[jira] [Commented] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

["James Nord (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493207#comment-17493207 ] 

James Nord commented on MRELEASE-899:
-------------------------------------

the problem still and has nothing to do with any tooling.

MREALESE changes the line ends period.  it should not rely on git to change them back or not or anything else.
XML parsing by computer not caring is also not important here. 
This causes a huge issue regardless of if the XML read by a machine is the same or not as when looking at git annotate it becomes a lot lot harder to see when a change (like a dependency) was introduced, as the last change will be at least the last release possibly newer.

> release:prepare should not change the line separator but detect effective line separator from pom.xml
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-899
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-899
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>            Reporter: Ralph van Etten
>            Priority: Major
>
> Currently the plugin use the system property {{line.separator}} when it rewrites the pom.xml.
> This causes trouble, because every line in changed, when a project is released sometimes under Windows and sometimes under Linux (because of its different line separators). (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the systems line separator but the line separator that is already used in the pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm someone else.
> Therefore it would be an great feature when there would be an property that define the expected behaviour, maybe in the same way it is done by the maven-assembly-plugin's property fileSet.lineEnding (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)