You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Mario Inchiosa <ma...@microsoft.com> on 2016/09/01 23:15:43 UTC
Bump Newtonsoft dependency
REEF.NET currently depends on Newtonsoft.Json 8.0.3, which is not .NET Core compliant. Shall we add a Jira to update to Newtonsoft.Json 9.0.1, which *is* .NET Core compliant?
Cheers,
Mario
Re: Bump Newtonsoft dependency
Posted by Markus Weimer <ma...@weimo.de>.
On Fri, Sep 23, 2016 at 10:36 AM, Markus Weimer <ma...@weimo.de> wrote:
> I filled an INFRA ticket for help:
>
> https://issues.apache.org/jira/browse/INFRA-12647
That issue is resolved. The user mailing list is now moderator-free.
Markus
Re: Bump Newtonsoft dependency
Posted by Markus Weimer <ma...@weimo.de>.
On 2016-09-23 10:15 AM, Markus Weimer wrote:
> Somehow the user list requires moderator approval, which it really
> shouldn't. I'll figure out why that is.
I filled an INFRA ticket for help:
https://issues.apache.org/jira/browse/INFRA-12647
Markus
Re: Bump Newtonsoft dependency
Posted by Markus Weimer <ma...@weimo.de>.
On 2016-09-22 11:23 AM, Mario Inchiosa wrote:
> I requested to join the "user" email list. Waiting > 1 day so far
> for moderator to accept the request.
yeah, that is my bad. Somehow the user list requires moderator approval,
which it really shouldn't. I'll figure out why that is.
Meanwhile, move forward with the mail to dev@ such that we can drive
this to a conclusion :)
Markus
Re: Bump Newtonsoft dependency
Posted by Mario Inchiosa <mi...@gmail.com>.
I requested to join the "user" email list. Waiting > 1 day so far for
moderator to accept the request. I'm trying to join so I can let users know
about the planned upgrade to Newtonsoft JSON 9.0.1.
On Wed, Sep 21, 2016 at 12:09 PM, Markus Weimer <ma...@weimo.de> wrote:
> On 2016-09-20 18:03, Mario Inchiosa wrote:
>
>> At http://reef.apache.org/mailing-list.html I only see mention of Dev and
>> Commits mailing lists. Where can I find out about the "user email list"?
>>
>
> Yeah, we did not publish the new version of the website with the
> information. It is still hidden in our repo:
>
> https://github.com/apache/reef/blob/master/website/src/site/
> markdown/mailing-list.md
>
> Markus
>
Re: Bump Newtonsoft dependency
Posted by Markus Weimer <ma...@weimo.de>.
On 2016-09-20 18:03, Mario Inchiosa wrote:
> At http://reef.apache.org/mailing-list.html I only see mention of Dev and
> Commits mailing lists. Where can I find out about the "user email list"?
Yeah, we did not publish the new version of the website with the
information. It is still hidden in our repo:
https://github.com/apache/reef/blob/master/website/src/site/markdown/mailing-list.md
Markus
Re: Bump Newtonsoft dependency
Posted by Mario Inchiosa <mi...@gmail.com>.
At http://reef.apache.org/mailing-list.html I only see mention of Dev and
Commits mailing lists. Where can I find out about the "user email list"?
On Mon, Sep 19, 2016 at 11:15 AM, Markus Weimer <ma...@weimo.de> wrote:
> On 2016-09-19 11:03 AM, Mario Inchiosa wrote:
>
>> We previously updated in March and in June. When we updated in March,
>> an advance email went out to alert folks. We could do something
>> similar again this time.
>>
>
> +1 And now that we have a user email list this, should go there as well.
>
> Markus
>
>
Re: Bump Newtonsoft dependency
Posted by Markus Weimer <ma...@weimo.de>.
On 2016-09-19 3:10 PM, Mario Inchiosa wrote:
> Should we post this message on the user email list? If so, should I
> do it, or should a committer?
Feel free to do it.
> Also, should I create a PR at this time?
Yes, go ahead. That triggers builds and all, so we are ready to merge
when nobody raises concerns.
Markus
Re: Bump Newtonsoft dependency
Posted by Mario Inchiosa <mi...@gmail.com>.
I have updated to Newtonsoft Json.NET version 9.0.1 and tested locally. I
have pushed the change to https://github.com/inchiosa/reef/tree/reef-1567
I have also composed the following message:
*We're planning to upgrade REEF to use Newtonsoft.Json version 9.0.1.*
*The suggested change is in branch
https://github.com/inchiosa/reef/tree/reef-1567
<https://github.com/inchiosa/reef/tree/reef-1567>*
*If you're concerned that this change might affect your use of REEF,
please test it and let us know if you encounter any issues.*
Should we post this message on the user email list? If so, should I do it,
or should a committer?
Also, should I create a PR at this time?
Cheers, Mario
On Mon, Sep 19, 2016 at 11:15 AM, Markus Weimer <ma...@weimo.de> wrote:
> On 2016-09-19 11:03 AM, Mario Inchiosa wrote:
>
>> We previously updated in March and in June. When we updated in March,
>> an advance email went out to alert folks. We could do something
>> similar again this time.
>>
>
> +1 And now that we have a user email list this, should go there as well.
>
> Markus
>
>
Re: Bump Newtonsoft dependency
Posted by Markus Weimer <ma...@weimo.de>.
On 2016-09-19 11:03 AM, Mario Inchiosa wrote:
> We previously updated in March and in June. When we updated in March,
> an advance email went out to alert folks. We could do something
> similar again this time.
+1 And now that we have a user email list this, should go there as well.
Markus
Re: Bump Newtonsoft dependency
Posted by Mario Inchiosa <mi...@gmail.com>.
I haven't heard objections, so I will create a Jira for updating Newtonsoft
Json.NET to version 9.0.1, targeted for inclusion in our 0.16 release.
We previously updated in March and in June. When we updated in March, an
advance email
<https://mail-archives.apache.org/mod_mbox/reef-dev/201603.mbox/%3CBL2PR03MB290BDD7F10D476CE5E6A4E4D2B50@BL2PR03MB290.namprd03.prod.outlook.com%3E>
went
out to alert folks. We could do something similar again this time.
-Mario
On Wed, Sep 7, 2016 at 8:23 AM, Markus Weimer <ma...@weimo.de> wrote:
> We've done this before. How do we get consensus on this, again? If the
> change goes into release 0.16, it should be OK, right?
>
> Markus
>
> On 2016-09-02 11:41 AM, Mariia Mykhailova wrote:
>
>> External projects which use REEF as a library.
>>
>>
>> -Mariia
>>
>> ________________________________
>> From: Mario Inchiosa <mi...@gmail.com>
>> Sent: Friday, September 2, 2016 10:22:11 AM
>> To: REEF Dev
>> Subject: Re: Bump Newtonsoft dependency
>>
>>
>> When you say "REEF clients" are you referring to the REEF client projects
>> under https://github.com/apache/reef/tree/master/lang/cs and included in
>> https://github.com/apache/reef/blob/master/lang/cs/Org.Apache.REEF.sln,
>> or
>> some other clients?
>>
>> On Thu, Sep 1, 2016 at 4:38 PM, Julia Wang (QIUHE) <
>> Qiuhe.Wang@microsoft.com
>>
>>> wrote:
>>>
>>
>> It needs to be synced with our client. REEF clients and REEF should use
>>> the same version to avoid dll conflict.
>>>
>>> -----Original Message-----
>>> From: Mario Inchiosa [mailto:marinch@microsoft.com]
>>> Sent: Thursday, September 1, 2016 4:16 PM
>>> To: dev@reef.apache.org
>>> Subject: Bump Newtonsoft dependency
>>>
>>> REEF.NET currently depends on Newtonsoft.Json 8.0.3, which is not .NET
>>> Core compliant. Shall we add a Jira to update to Newtonsoft.Json 9.0.1,
>>> which *is* .NET Core compliant?
>>>
>>> Cheers,
>>> Mario
>>>
>>>
>>
Re: Bump Newtonsoft dependency
Posted by Markus Weimer <ma...@weimo.de>.
We've done this before. How do we get consensus on this, again? If the
change goes into release 0.16, it should be OK, right?
Markus
On 2016-09-02 11:41 AM, Mariia Mykhailova wrote:
> External projects which use REEF as a library.
>
>
> -Mariia
>
> ________________________________
> From: Mario Inchiosa <mi...@gmail.com>
> Sent: Friday, September 2, 2016 10:22:11 AM
> To: REEF Dev
> Subject: Re: Bump Newtonsoft dependency
>
> When you say "REEF clients" are you referring to the REEF client projects
> under https://github.com/apache/reef/tree/master/lang/cs and included in
> https://github.com/apache/reef/blob/master/lang/cs/Org.Apache.REEF.sln, or
> some other clients?
>
> On Thu, Sep 1, 2016 at 4:38 PM, Julia Wang (QIUHE) <Qiuhe.Wang@microsoft.com
>> wrote:
>
>> It needs to be synced with our client. REEF clients and REEF should use
>> the same version to avoid dll conflict.
>>
>> -----Original Message-----
>> From: Mario Inchiosa [mailto:marinch@microsoft.com]
>> Sent: Thursday, September 1, 2016 4:16 PM
>> To: dev@reef.apache.org
>> Subject: Bump Newtonsoft dependency
>>
>> REEF.NET currently depends on Newtonsoft.Json 8.0.3, which is not .NET
>> Core compliant. Shall we add a Jira to update to Newtonsoft.Json 9.0.1,
>> which *is* .NET Core compliant?
>>
>> Cheers,
>> Mario
>>
>
Re: Bump Newtonsoft dependency
Posted by Mariia Mykhailova <ma...@microsoft.com>.
External projects which use REEF as a library.
-Mariia
________________________________
From: Mario Inchiosa <mi...@gmail.com>
Sent: Friday, September 2, 2016 10:22:11 AM
To: REEF Dev
Subject: Re: Bump Newtonsoft dependency
When you say "REEF clients" are you referring to the REEF client projects
under https://github.com/apache/reef/tree/master/lang/cs and included in
https://github.com/apache/reef/blob/master/lang/cs/Org.Apache.REEF.sln, or
some other clients?
On Thu, Sep 1, 2016 at 4:38 PM, Julia Wang (QIUHE) <Qiuhe.Wang@microsoft.com
> wrote:
> It needs to be synced with our client. REEF clients and REEF should use
> the same version to avoid dll conflict.
>
> -----Original Message-----
> From: Mario Inchiosa [mailto:marinch@microsoft.com]
> Sent: Thursday, September 1, 2016 4:16 PM
> To: dev@reef.apache.org
> Subject: Bump Newtonsoft dependency
>
> REEF.NET currently depends on Newtonsoft.Json 8.0.3, which is not .NET
> Core compliant. Shall we add a Jira to update to Newtonsoft.Json 9.0.1,
> which *is* .NET Core compliant?
>
> Cheers,
> Mario
>
Re: Bump Newtonsoft dependency
Posted by Mario Inchiosa <mi...@gmail.com>.
When you say "REEF clients" are you referring to the REEF client projects
under https://github.com/apache/reef/tree/master/lang/cs and included in
https://github.com/apache/reef/blob/master/lang/cs/Org.Apache.REEF.sln, or
some other clients?
On Thu, Sep 1, 2016 at 4:38 PM, Julia Wang (QIUHE) <Qiuhe.Wang@microsoft.com
> wrote:
> It needs to be synced with our client. REEF clients and REEF should use
> the same version to avoid dll conflict.
>
> -----Original Message-----
> From: Mario Inchiosa [mailto:marinch@microsoft.com]
> Sent: Thursday, September 1, 2016 4:16 PM
> To: dev@reef.apache.org
> Subject: Bump Newtonsoft dependency
>
> REEF.NET currently depends on Newtonsoft.Json 8.0.3, which is not .NET
> Core compliant. Shall we add a Jira to update to Newtonsoft.Json 9.0.1,
> which *is* .NET Core compliant?
>
> Cheers,
> Mario
>
RE: Bump Newtonsoft dependency
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
It needs to be synced with our client. REEF clients and REEF should use the same version to avoid dll conflict.
-----Original Message-----
From: Mario Inchiosa [mailto:marinch@microsoft.com]
Sent: Thursday, September 1, 2016 4:16 PM
To: dev@reef.apache.org
Subject: Bump Newtonsoft dependency
REEF.NET currently depends on Newtonsoft.Json 8.0.3, which is not .NET Core compliant. Shall we add a Jira to update to Newtonsoft.Json 9.0.1, which *is* .NET Core compliant?
Cheers,
Mario