You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/07/03 03:23:40 UTC

[GitHub] [storm] Ethanlm commented on a change in pull request #3067: STORM-3442 Add owner to supervisor summary

Ethanlm commented on a change in pull request #3067: STORM-3442 Add owner to supervisor summary
URL: https://github.com/apache/storm/pull/3067#discussion_r299755681
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/generated/NumErrorsChoice.java
 ##########
 @@ -39,7 +39,6 @@ private NumErrorsChoice(int value) {
   /**
    * Get the integer value of this enum value, as defined in the Thrift IDL.
    */
-  @Override
 
 Review comment:
   In case someone is curious (like me),  https://github.com/apache/storm/pull/3020 modified these generated file (NumErrorsChoice.java and TopologyInitialStatus.java) directly. So the rerun of `genthrift.sh` in this PR overrides the change.  And this is good.
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services