You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Andreas L Delmelle <a_...@pandora.be> on 2007/10/24 22:40:25 UTC

Markers on empty fo:inlines

Hi devs

In response to a recent post on fop-users, I tried adding support for  
markers in fo:inline. By itself, not a difficult fix. I just followed  
the example in the LMs where it does work (block-level). Kumar (the  
OP) mailed to me off-list that the fix still wasn't working for him,  
and I bumped into the fact that empty fo:inlines were used (addAreas 
() was not called).

Now I'm wondering about the return statement in  
InlineLM.getNextKnuthElements()

return returnList.size() == 0 ? null : returnList;

Can anyone remember why it was written this way? Was that to avoid  
exceptions or erroneous behaviour? With the above, it seems like the  
following would also not work:

<fo:inline id="empty1" />
...

<fo:basic-link internal-destination="empty1">...</fo:basic-link>

IIC, since the returnList is null, the id will not be registered,  
which is inconsistent behaviour in comparison to fo:block...

Can this line be safely changed to simply 'return returnList;', or  
are there consequences to that change that I'm overlooking?



Cheers

Andreas