[GitHub] [incubator-shardingsphere] taojintianxia commented on a change in pull request #3883: Code style revise for shadow feature

[GitBox <gi...@apache.org>]

taojintianxia commented on a change in pull request #3883: Code style revise for shadow feature
URL: https://github.com/apache/incubator-shardingsphere/pull/3883#discussion_r363305335
 
 

 ##########
 File path: shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/PreparedJudgementEngine.java
 ##########
 @@ -41,16 +41,16 @@
  * @author zhyee
  */
 @RequiredArgsConstructor
-public final class PreparedJudgementEngine extends ShadowJudgementEngine {
-
+public final class PreparedJudgementEngine implements ShadowJudgementEngine {
+    
     private final ShadowRule shadowRule;
-
+    
     private final SQLStatementContext sqlStatementContext;
-
+    
     private final List<Object> parameters;
-
+    
     @Override
-    public boolean isShadowSql() {
+    public boolean isShadowSQL() {
         if (sqlStatementContext.getSqlStatement() instanceof InsertStatement) {
 
 Review comment:
   why you make SQL in upper case in isShadowSQL but not in getSqlStatement() ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services