You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/14 03:17:03 UTC

[GitHub] [spark] LuciferYang opened a new pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

LuciferYang opened a new pull request #35839:
URL: https://github.com/apache/spark/pull/35839


   ### What changes were proposed in this pull request?
   This pr aims to upgrade log4j2 to 2.17.2.
   
   
   ### Why are the changes needed?
   This version brings a lot of fixes released to log1.x support, the release notes and change report as follows:
   
   - https://logging.apache.org/log4j/2.x/index.html#News
   - https://logging.apache.org/log4j/2.x/changes-report.html#a2.17.2
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Pass GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35839:
URL: https://github.com/apache/spark/pull/35839#issuecomment-1068179225


   Thank you for reverting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikun commented on pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35839:
URL: https://github.com/apache/spark/pull/35839#issuecomment-1067982024


   
   
   
   ![image](https://user-images.githubusercontent.com/1736354/158386473-eacdfb14-69d2-4a58-9ae5-f453f20b3b1e.png)
   The K8S IT break since this commits. 
   
   - Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j2.properties *** FAILED *** (3 minutes, 14 seconds)
   
   https://github.com/Yikun/spark/runs/5543930959?check_suite_focus=true
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikun edited a comment on pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35839:
URL: https://github.com/apache/spark/pull/35839#issuecomment-1067982024


   
   
   ![image](https://user-images.githubusercontent.com/1736354/158386473-eacdfb14-69d2-4a58-9ae5-f453f20b3b1e.png)
   The K8S IT break since this commit. 
   
   - Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j2.properties *** FAILED *** (3 minutes, 14 seconds)
   
   https://github.com/Yikun/spark/runs/5543930959?check_suite_focus=true
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35839:
URL: https://github.com/apache/spark/pull/35839#issuecomment-1067508391


   thanks all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikun edited a comment on pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35839:
URL: https://github.com/apache/spark/pull/35839#issuecomment-1067982024


   
   ![image](https://user-images.githubusercontent.com/1736354/158386473-eacdfb14-69d2-4a58-9ae5-f453f20b3b1e.png)
   FYI, the [K8S IT](https://github.com/apache/spark/pull/35830) break since this commit:
   
   - Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j2.properties *** FAILED *** (3 minutes, 14 seconds)
   
   https://github.com/Yikun/spark/runs/5543930959?check_suite_focus=true
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #35839:
URL: https://github.com/apache/spark/pull/35839#issuecomment-1068010389


   Reverted through https://github.com/apache/spark/commit/2a63fea139ec7e5d0883ccd5b33080bdad21e009


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35839:
URL: https://github.com/apache/spark/pull/35839#issuecomment-1067996323


   @dongjoon-hyun @yaooqinn should revert this first? I haven't found the cause of the failure yet
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35839:
URL: https://github.com/apache/spark/pull/35839


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikun edited a comment on pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35839:
URL: https://github.com/apache/spark/pull/35839#issuecomment-1067982024


   
   
   ![image](https://user-images.githubusercontent.com/1736354/158386473-eacdfb14-69d2-4a58-9ae5-f453f20b3b1e.png)
   FYI, the K8S IT break since this commit:
   
   - Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j2.properties *** FAILED *** (3 minutes, 14 seconds)
   
   https://github.com/Yikun/spark/runs/5543930959?check_suite_focus=true
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #35839: [SPARK-38544][BUILD] Upgrade log4j2 to 2.17.2

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35839:
URL: https://github.com/apache/spark/pull/35839#issuecomment-1068012456


   thanks @wangyum 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org