You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/25 12:14:00 UTC
[jira] [Work logged] (HIVE-26069) Remove unnecessary items from the .gitignore
[ https://issues.apache.org/jira/browse/HIVE-26069?focusedWorklogId=747762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747762 ]
ASF GitHub Bot logged work on HIVE-26069:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/22 12:13
Start Date: 25/Mar/22 12:13
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #3139:
URL: https://github.com/apache/hive/pull/3139#discussion_r835211948
##########
File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Derby.java
##########
@@ -88,7 +88,7 @@ public String getInitialJdbcUrl(String hostAddress) {
}
public String getDb() {
- return MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
+ return "${test.tmp.dir}/" + MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
Review comment:
I don't think this is necessary. First it is not going to be replaced like that and second it is used in conjunction with an in-memory derby so no DB file is created in the file-system.
##########
File path: standalone-metastore/metastore-server/pom.xml
##########
@@ -573,6 +573,9 @@
<java.io.tmpdir>${test.tmp.dir}</java.io.tmpdir>
<test.tmp.dir>${test.tmp.dir}</test.tmp.dir>
<hive.in.test>true</hive.in.test>
+ <derby.version>${derby.version}</derby.version>
+ <derby.stream.error.file>${test.tmp.dir}/derby.log</derby.stream.error.file>
+ <javax.jdo.option.ConnectionURL>jdbc:derby:memory:${test.tmp.dir}/junit_metastore_db;create=true</javax.jdo.option.ConnectionURL>
Review comment:
This is a `MetastoreConf` property, it doesn't feel right to put it here. Also, I am not sure if every test should use an Derby database and specifically in-memory. Why is this change needed?
##########
File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Derby.java
##########
@@ -88,7 +88,7 @@ public String getInitialJdbcUrl(String hostAddress) {
}
public String getDb() {
- return MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
+ return "${test.tmp.dir}/" + MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
Review comment:
https://db.apache.org/derby/docs/10.8/devguide/cdevdvlp17453.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 747762)
Remaining Estimate: 0h
Time Spent: 10m
> Remove unnecessary items from the .gitignore
> --------------------------------------------
>
> Key: HIVE-26069
> URL: https://issues.apache.org/jira/browse/HIVE-26069
> Project: Hive
> Issue Type: Task
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently .gitignore contains files which are generated by test and either should be removed by those given test or preferably they should be created under the target directories.
> Some of the that we have seen are:
> - metastore_db
> - derby.log
> - datanucleus.log
> Also it might worth to explore why the following directories are not showing up in the {{git status}}:
> - streaming/${test.tmp.dir}
> - itests/hive-unit/cmroot
--
This message was sent by Atlassian Jira
(v8.20.1#820001)