(arrow-adbc) branch main updated: build(c): run nightly clang with `-Wdocumentation` (#3298)

[li...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new a1a337ea2 build(c): run nightly clang with `-Wdocumentation` (#3298)
a1a337ea2 is described below

commit a1a337ea2c76c77bc20f5288f3b8fa02e614adde
Author: David Li <li...@gmail.com>
AuthorDate: Fri Aug 22 09:28:45 2025 +0900

    build(c): run nightly clang with `-Wdocumentation` (#3298)
    
    Fixes #3145.
---
 c/cmake_modules/AdbcDefines.cmake  | 8 ++++++--
 c/driver/sqlite/statement_reader.h | 2 +-
 compose.yaml                       | 4 ++++
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/c/cmake_modules/AdbcDefines.cmake b/c/cmake_modules/AdbcDefines.cmake
index d511abb1c..11fe1a5d2 100644
--- a/c/cmake_modules/AdbcDefines.cmake
+++ b/c/cmake_modules/AdbcDefines.cmake
@@ -20,6 +20,10 @@
 
 enable_language(C CXX)
 
+if(${CMAKE_VERSION} VERSION_GREATER "3.24")
+  cmake_policy(SET CMP0135 NEW)
+endif()
+
 set(BUILD_SUPPORT_DIR "${REPOSITORY_ROOT}/ci/build_support")
 
 include(CheckLinkerFlag)
@@ -137,8 +141,8 @@ else()
 endif()
 
 macro(adbc_configure_target TARGET)
-  target_compile_options(${TARGET}
-                         PRIVATE ${ADBC_C_CXX_FLAGS_${ADBC_BUILD_WARNING_LEVEL}})
+  target_compile_options(${TARGET} PRIVATE ${ADBC_C_CXX_FLAGS_${ADBC_BUILD_WARNING_LEVEL}}
+                                           ${ADBC_CXXFLAGS})
 endmacro()
 
 # Common testing setup
diff --git a/c/driver/sqlite/statement_reader.h b/c/driver/sqlite/statement_reader.h
index 7563cd552..a2851f9cb 100644
--- a/c/driver/sqlite/statement_reader.h
+++ b/c/driver/sqlite/statement_reader.h
@@ -55,7 +55,7 @@ void InternalAdbcSqliteBinderRelease(struct AdbcSqliteBinder* binder);
 /// \param[in] db The SQLite connection.
 /// \param[in] stmt The SQLite statement.
 /// \param[in] binder Query parameters to bind, if provided.
-/// \param[in] infer_rows How many rows to read to infer the Arrow schema.
+/// \param[in] batch_size How many rows to read to infer the Arrow schema.
 /// \param[out] stream The stream to export to.
 /// \param[out] error Error details, if needed.
 ADBC_EXPORT
diff --git a/compose.yaml b/compose.yaml
index e7ebde91f..90713b8b6 100644
--- a/compose.yaml
+++ b/compose.yaml
@@ -40,6 +40,8 @@ services:
         GO: ${GO}
     volumes:
       - .:/adbc:delegated
+    environment:
+      ADBC_CMAKE_ARGS: "-DADBC_CXXFLAGS=-Wdocumentation -DADBC_BUILD_WARNING_LEVEL=CHECKIN"
     command: "bash -c 'git config --global --add safe.directory /adbc && /adbc/ci/scripts/cpp_build.sh /adbc /adbc/build/clang-latest && env BUILD_ALL=0 BUILD_DRIVER_MANAGER=1 BUILD_DRIVER_SQLITE=1 /adbc/ci/scripts/cpp_test.sh /adbc/build/clang-latest'"
 
   cpp-gcc-latest:
@@ -52,6 +54,8 @@ services:
         GO: ${GO}
     volumes:
       - .:/adbc:delegated
+    environment:
+      ADBC_CMAKE_ARGS: "-DADBC_BUILD_WARNING_LEVEL=CHECKIN"
     command: "bash -c 'git config --global --add safe.directory /adbc && /adbc/ci/scripts/cpp_build.sh /adbc /adbc/build/gcc-latest && env BUILD_ALL=0 BUILD_DRIVER_MANAGER=1 BUILD_DRIVER_SQLITE=1 /adbc/ci/scripts/cpp_test.sh /adbc/build/gcc-latest'"
 
   # Build and dynamically load shared drivers missing the common entrypoints