You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Mike Perry (JIRA)" <ji...@apache.org> on 2017/02/05 06:19:41 UTC
[jira] [Updated] (AIRFLOW-839) docker_operator.py attempts to log
status key without first checking existence
[ https://issues.apache.org/jira/browse/AIRFLOW-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Perry updated AIRFLOW-839:
-------------------------------
Description:
When pulling a docker image, docker_operator.py attempts to log the `status` key each time it gets output. This is usually fine, but occasionaly no `status` key exists. We've seen this happen when we run out of inode space in our cluster and the docker cli is unable to extract the image. This is consistent with the docker HTTP api docs (https://docs.docker.com/engine/api/v1.24/#create-an-image). If an error occurs, there won't be a `status` key. There will be an `error` key.
This is a relatively minor bug, but it obscures the real issue and can sometimes make it difficult to figure out what went wrong.
If you agree this should be fixed, I can submit a pr that first checks for status before logging.
here's the code that would need changed: https://github.com/apache/incubator-airflow/blob/master/airflow/operators/docker_operator.py#L156
was:
When pulling a docker image, docker_operator.py attempts to log the `status` key each time it gets output. This is usually fine, but occasionaly no `status` key exists. We've seen this happen when we run out of inode space in our cluster and the docker cli is unable to extract the image. This is consistent with the docker HTTP api docs (https://docs.docker.com/engine/api/v1.24/#create-an-image). If an error occurs, there won't be a `status` key. There will be an `error` key.
This is a relatively minor bug, but it obscures the real issue and can sometimes make it difficult to figure out what went wrong.
> docker_operator.py attempts to log status key without first checking existence
> ------------------------------------------------------------------------------
>
> Key: AIRFLOW-839
> URL: https://issues.apache.org/jira/browse/AIRFLOW-839
> Project: Apache Airflow
> Issue Type: Bug
> Components: docker
> Affects Versions: Airflow 1.7.1
> Environment: arch linux
> python 2.7 and python 3
> Reporter: Mike Perry
> Assignee: Mike Perry
> Priority: Trivial
>
> When pulling a docker image, docker_operator.py attempts to log the `status` key each time it gets output. This is usually fine, but occasionaly no `status` key exists. We've seen this happen when we run out of inode space in our cluster and the docker cli is unable to extract the image. This is consistent with the docker HTTP api docs (https://docs.docker.com/engine/api/v1.24/#create-an-image). If an error occurs, there won't be a `status` key. There will be an `error` key.
> This is a relatively minor bug, but it obscures the real issue and can sometimes make it difficult to figure out what went wrong.
> If you agree this should be fixed, I can submit a pr that first checks for status before logging.
> here's the code that would need changed: https://github.com/apache/incubator-airflow/blob/master/airflow/operators/docker_operator.py#L156
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)