You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/04 15:57:00 UTC
[jira] [Commented] (FLINK-7102) improve ClassLoaderITCase

    [ https://issues.apache.org/jira/browse/FLINK-7102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073859#comment-16073859 ] 

ASF GitHub Bot commented on FLINK-7102:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4255

    [FLINK-7102] improve ClassLoaderITCase

    * ClassLoaderITCase unnecessarily runs multiple tests in a single test case
    * ClassLoaderITCase#testDisposeSavepointWithCustomKvState() does not cancel its
      job (thus the order of execution of test cases defines the outcome)
    * ClassLoaderITCase uses e.getCause().getCause() which may cause
      {{NullPointerException}}s hiding the original error

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7102

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4255
    
----
commit 87f28e5d972d33c82f44c05ab62743cb614e5239
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-07-04T11:49:55Z

    [FLINK-7102] improve ClassLoaderITCase
    
    * ClassLoaderITCase unnecessarily runs multiple tests in a single test case
    * ClassLoaderITCase#testDisposeSavepointWithCustomKvState() does not cancel its
      job (thus the order of execution of test cases defines the outcome)
    * ClassLoaderITCase uses e.getCause().getCause() which may cause
      {{NullPointerException}}s hiding the original error

----


> improve ClassLoaderITCase
> -------------------------
>
>                 Key: FLINK-7102
>                 URL: https://issues.apache.org/jira/browse/FLINK-7102
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> {{ClassLoaderITCase}}...
> * unnecessarily runs multiple tests in a single test case
> * {{#testDisposeSavepointWithCustomKvState()}} does not cancel its job (thus the order of execution of test cases defines the outcome)
> * uses {{e.getCause().getCause()}} which may cause {{NullPointerException}}s hiding the original error



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)