You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Sangjin Lee (JIRA)" <ji...@apache.org> on 2007/12/08 23:35:43 UTC

[jira] Created: (GERONIMO-3689) should provide additional thread pool to isolate running of the callback & event notification

should provide additional thread pool to isolate running of the callback & event notification
---------------------------------------------------------------------------------------------

                 Key: GERONIMO-3689
                 URL: https://issues.apache.org/jira/browse/GERONIMO-3689
             Project: Geronimo
          Issue Type: Improvement
      Security Level: public (Regular issues)
          Components: AsyncHttpClient
    Affects Versions: 1.x
            Reporter: Sangjin Lee


The mina 1.1 documentation recommends disabling the default ThreadModel, as well as additionally providing an ExecutorFilter to isolate code that runs when events are notified (IoHandler) and thus in our case callback code.

The default ThreadModel should be disabled by SocketConnectorConfig.setThreadModel(ThreadModel.MANUAL), and there should be an option of supplying a thread pool at the end of the filter chain.

Please see http://mina.apache.org/configuring-thread-model.html for more discussion...


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3689) should provide additional thread pool to isolate running of the callback & event notification

Posted by "Sangjin Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sangjin Lee updated GERONIMO-3689:
----------------------------------

    Attachment: 3689.patch

a suggested patch

> should provide additional thread pool to isolate running of the callback & event notification
> ---------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3689
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3689
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>         Attachments: 3689.patch
>
>
> The mina 1.1 documentation recommends disabling the default ThreadModel, as well as additionally providing an ExecutorFilter to isolate code that runs when events are notified (IoHandler) and thus in our case callback code.
> The default ThreadModel should be disabled by SocketConnectorConfig.setThreadModel(ThreadModel.MANUAL), and there should be an option of supplying a thread pool at the end of the filter chain.
> Please see http://mina.apache.org/configuring-thread-model.html for more discussion...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-3689) should provide additional thread pool to isolate running of the callback & event notification

Posted by "Rick McGuire (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rick McGuire resolved GERONIMO-3689.
------------------------------------

    Resolution: Fixed

Committed revision 603700.

Very nice patch.  This is not only a good enhancement, but it brings the implementation around to the recommended way of writing mina applications.  Much simpler to implement than I expected. 

> should provide additional thread pool to isolate running of the callback & event notification
> ---------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3689
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3689
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>         Attachments: 3689.patch
>
>
> The mina 1.1 documentation recommends disabling the default ThreadModel, as well as additionally providing an ExecutorFilter to isolate code that runs when events are notified (IoHandler) and thus in our case callback code.
> The default ThreadModel should be disabled by SocketConnectorConfig.setThreadModel(ThreadModel.MANUAL), and there should be an option of supplying a thread pool at the end of the filter chain.
> Please see http://mina.apache.org/configuring-thread-model.html for more discussion...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3689) should provide additional thread pool to isolate running of the callback & event notification

Posted by "Sangjin Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550839 ] 

Sangjin Lee commented on GERONIMO-3689:
---------------------------------------

I have a patch ready for this, but earlier patches are kind of backed up, so I'll wait until they're cleared.

> should provide additional thread pool to isolate running of the callback & event notification
> ---------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3689
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3689
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>
> The mina 1.1 documentation recommends disabling the default ThreadModel, as well as additionally providing an ExecutorFilter to isolate code that runs when events are notified (IoHandler) and thus in our case callback code.
> The default ThreadModel should be disabled by SocketConnectorConfig.setThreadModel(ThreadModel.MANUAL), and there should be an option of supplying a thread pool at the end of the filter chain.
> Please see http://mina.apache.org/configuring-thread-model.html for more discussion...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-3689) should provide additional thread pool to isolate running of the callback & event notification

Posted by "Rick McGuire (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rick McGuire closed GERONIMO-3689.
----------------------------------


> should provide additional thread pool to isolate running of the callback & event notification
> ---------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3689
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3689
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>         Attachments: 3689.patch
>
>
> The mina 1.1 documentation recommends disabling the default ThreadModel, as well as additionally providing an ExecutorFilter to isolate code that runs when events are notified (IoHandler) and thus in our case callback code.
> The default ThreadModel should be disabled by SocketConnectorConfig.setThreadModel(ThreadModel.MANUAL), and there should be an option of supplying a thread pool at the end of the filter chain.
> Please see http://mina.apache.org/configuring-thread-model.html for more discussion...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3689) should provide additional thread pool to isolate running of the callback & event notification

Posted by "Rick McGuire (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550912 ] 

Rick McGuire commented on GERONIMO-3689:
----------------------------------------

I think I have the patch backlog cleared up now, if you'd like to submit the patch.  If I'm mistaken and there are other pending patches, please let me know. 

> should provide additional thread pool to isolate running of the callback & event notification
> ---------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3689
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3689
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>
> The mina 1.1 documentation recommends disabling the default ThreadModel, as well as additionally providing an ExecutorFilter to isolate code that runs when events are notified (IoHandler) and thus in our case callback code.
> The default ThreadModel should be disabled by SocketConnectorConfig.setThreadModel(ThreadModel.MANUAL), and there should be an option of supplying a thread pool at the end of the filter chain.
> Please see http://mina.apache.org/configuring-thread-model.html for more discussion...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.