You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/08 07:07:21 UTC
[GitHub] [arrow] thisisnic opened a new pull request #11363: ARROW-14069: [R] By default, filter out hash functions in list_compute_functions()
thisisnic opened a new pull request #11363:
URL: https://github.com/apache/arrow/pull/11363
Filter the following functions from `list_compute_functions()`:
* start with "hash_"
* `index_in_meta_binary`
* `is_in_meta_binary`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #11363: ARROW-14069: [R] By default, filter out hash functions in list_compute_functions()
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #11363:
URL: https://github.com/apache/arrow/pull/11363#discussion_r725020036
##########
File path: r/R/compute.R
##########
@@ -97,6 +97,13 @@ list_compute_functions <- function(pattern = NULL, ...) {
if (!is.null(pattern)) {
funcs <- grep(pattern, funcs, value = TRUE, ...)
}
+ # TODO: Filtering of hash funcs will already happen in C++ with ARROW-13943
+ funcs <- grep(
+ "^hash_|index_in_meta_binary|is_in_meta_binary",
Review comment:
There was a comment on the ticket suggesting otherwise and I didn't look into it thoroughly enough; I've removed those from the things to filter out now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #11363: ARROW-14069: [R] By default, filter out hash functions in list_compute_functions()
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #11363:
URL: https://github.com/apache/arrow/pull/11363#discussion_r725229385
##########
File path: r/R/compute.R
##########
@@ -97,6 +97,13 @@ list_compute_functions <- function(pattern = NULL, ...) {
if (!is.null(pattern)) {
funcs <- grep(pattern, funcs, value = TRUE, ...)
}
+ # TODO: Filtering of hash funcs will already happen in C++ with ARROW-13943
+ funcs <- grep(
+ "^hash_|index_in_meta_binary|is_in_meta_binary",
Review comment:
Ah, yep, I just tested them and they do appear to be binary variants of the unary kernels. I opened ARROW-14262 for discussion and to track documenting the kernels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #11363: ARROW-14069: [R] By default, filter out hash functions in list_compute_functions()
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #11363:
URL: https://github.com/apache/arrow/pull/11363#discussion_r725223787
##########
File path: r/R/compute.R
##########
@@ -97,6 +97,13 @@ list_compute_functions <- function(pattern = NULL, ...) {
if (!is.null(pattern)) {
funcs <- grep(pattern, funcs, value = TRUE, ...)
}
+ # TODO: Filtering of hash funcs will already happen in C++ with ARROW-13943
+ funcs <- grep(
+ "^hash_|index_in_meta_binary|is_in_meta_binary",
Review comment:
IIRC `is_in` is unary and takes the lookup table as an option; the `_meta_binary` version is binary instead. We don't use the _meta_binary in the query engine for performance concerns but it was convenient to use when calling more directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #11363: ARROW-14069: [R] By default, filter out hash functions in list_compute_functions()
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #11363:
URL: https://github.com/apache/arrow/pull/11363#discussion_r724976516
##########
File path: r/R/compute.R
##########
@@ -97,6 +97,13 @@ list_compute_functions <- function(pattern = NULL, ...) {
if (!is.null(pattern)) {
funcs <- grep(pattern, funcs, value = TRUE, ...)
}
+ # TODO: Filtering of hash funcs will already happen in C++ with ARROW-13943
+ funcs <- grep(
+ "^hash_|index_in_meta_binary|is_in_meta_binary",
Review comment:
Why filter out index/is_in_meta_binary? You can call them, and we in fact use index_in_meta_binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11363: ARROW-14069: [R] By default, filter out hash functions in list_compute_functions()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11363:
URL: https://github.com/apache/arrow/pull/11363#issuecomment-938399207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #11363: ARROW-14069: [R] By default, filter out hash functions in list_compute_functions()
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #11363:
URL: https://github.com/apache/arrow/pull/11363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #11363: ARROW-14069: [R] By default, filter out hash functions in list_compute_functions()
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #11363:
URL: https://github.com/apache/arrow/pull/11363#discussion_r725213234
##########
File path: r/R/compute.R
##########
@@ -97,6 +97,13 @@ list_compute_functions <- function(pattern = NULL, ...) {
if (!is.null(pattern)) {
funcs <- grep(pattern, funcs, value = TRUE, ...)
}
+ # TODO: Filtering of hash funcs will already happen in C++ with ARROW-13943
+ funcs <- grep(
+ "^hash_|index_in_meta_binary|is_in_meta_binary",
Review comment:
That comment came from me I assume. @nealrichardson can you explain what the difference is between `is_in` and `is_in_meta_binary` or `index_in` and `index_in_meta_binary`? If the `_meta_binary` variants truly are needed then we should add documentation for them. Currently they are missing doc strings of any kind in python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org