You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/05/04 14:04:48 UTC

[jira] [Updated] (BOOKKEEPER-235) Bad syncing in entrylogger degrades performance for many concurrent ledgers

     [ https://issues.apache.org/jira/browse/BOOKKEEPER-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-235:
----------------------------------

    Attachment: BOOKKEEPER-235.diff

The problem was that the flush thread was syncing on entryLogger, while EntryLogger#addEntry is also synchronised, so they were holding each other off. 

Fix is two liner.
                
> Bad syncing in entrylogger degrades performance for many concurrent ledgers
> ---------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-235
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-235
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Blocker
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-235.diff
>
>
> EntryLogger flush syncs on the wrong object, which really hurts performance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira