You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "B. W. Fitzpatrick" <fi...@red-bean.com> on 2001/02/27 04:49:43 UTC
filesystem build broken or is it just me?
Finally decided to start poking around in the filesystem and can't get
it to build. Applied Yoshiki's patch to dag.h first. Up to date
working copy and clean build.
$ cvs up -d
$ make distclean
$ ./autogen.sh && ./configure --with-maintainer-mode \
--disable-shared \
--with-berkeley-db=/usr/local/BerkeleyDB.3.2 \
&& make
<massive elision>...
Making all in libsvn_fs
make[3]: Entering directory `/disk/hdb1/bwf/cvs-work/subversion/subversion/libsvn_fs'
/bin/sh ../../libtool --silent --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../subversion/include -I../../apr/include -I../../expat-lite -D_REENTRANT -I/usr/local/BerkeleyDB.3.2/include -pthread -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -Wshadow -DSVN_DEBUG -DAP_DEBUG -g -Wall -c dag.c
dag.c: In function `find_dir_entry':
dag.c:229: structure has no member named `contents'
dag.c:238: structure has no member named `contents'
dag.c:242: structure has no member named `entry'
dag.c: In function `node_is_kind_p':
dag.c:264: structure has no member named `contents'
dag.c: In function `svn_fs__dag_is_mutable':
dag.c:315: structure has no member named `contents'
dag.c: In function `svn_fs__dag_get_proplist':
dag.c:328: structure has no member named `contents'
dag.c: In function `svn_fs__dag_set_proplist':
dag.c:382: structure has no member named `contents'
dag.c: In function `svn_fs__dag_revision_root':
dag.c:416: structure has no member named `contents'
dag.c: In function `svn_fs__dag_txn_root':
dag.c:440: structure has no member named `contents'
dag.c: In function `svn_fs__dag_clone_child':
dag.c:486: structure has no member named `contents'
dag.c:503: structure has no member named `contents'
dag.c:503: structure has no member named `contents'
dag.c: In function `svn_fs__dag_clone_root':
dag.c:557: structure has no member named `contents'
dag.c: In function `svn_fs__dag_delete':
dag.c:599: structure has no member named `contents'
dag.c: In function `make_entry':
dag.c:812: structure has no member named `contents'
dag.c: In function `svn_fs__dag_set_contents':
dag.c:863: structure has no member named `contents'
dag.c: In function `svn_fs__dag_open':
dag.c:947: structure has no member named `contents'
dag.c: At top level:
dag.c:168: warning: `get_node_revision_cached' defined but not used
dag.c:193: warning: `set_node_revision_cached' defined but not used
make[3]: *** [dag.lo] Error 1
make[3]: Leaving directory `/disk/hdb1/bwf/cvs-work/subversion/subversion/libsvn_fs'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/disk/hdb1/bwf/cvs-work/subversion/subversion'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/disk/hdb1/bwf/cvs-work/subversion'
make: *** [all-recursive-am] Error 2
..cvs-work/subversion$
Am I missing something?
-Fitz
Re: filesystem build broken or is it just me?
Posted by Yoshiki Hayashi <yo...@xemacs.org>.
"B. W. Fitzpatrick" <fi...@red-bean.com> writes:
> Finally decided to start poking around in the filesystem and can't get
> it to build. Applied Yoshiki's patch to dag.h first. Up to date
> working copy and clean build.
I do get the same error. It's intentionally done by this
commit.
User: jimb
Date: 01/02/26 09:54:07
Modified: subversion/libsvn_fs dag.c
Log:
* libsvn_fs/dag.c (dag_node_t): Rename `contents' member to
`node_revision'. There are new rules for accessing this member, and
this makes sure any code referring to `contents' will break.
(uncache_node_revision, cache_node_revision, get_node_revision_cached,
set_node_revision_cached): New functions.
I workaround this by adding back contents member to
dag_node_t and compiler found a real bug. :-)
Index: dag.c
===================================================================
RCS file: /cvs/subversion/subversion/libsvn_fs/dag.c,v
retrieving revision 1.49
diff -u -r1.49 dag.c
--- dag.c 2001/02/27 00:52:00 1.49
+++ dag.c 2001/02/27 06:03:37
@@ -239,7 +240,7 @@
skel_t *entry = entry_list->children;
/* search the entry list for one whose name matches NAME. */
- for (entry = entry_list->children; entry; entry->entry->next)
+ for (entry = entry_list->children; entry; entry = entry->next)
if (svn_fs__matches_atom (entry->children, name))
return entry;
}
--
Yoshiki Hayashi
Re: filesystem build broken or is it just me?
Posted by Jim Blandy <ji...@zwingli.cygnus.com>.
Karl Fogel <kf...@galois.ch.collab.net> writes:
> If you consciously break the build, please state so _prominently_ in
> your commit message, so anyone casually reviewing the logs (say,
> because they can't build) will see the notice.
Sorry --- I'll try to remember this in the future.
Re: filesystem build broken or is it just me?
Posted by Karl Fogel <kf...@galois.collab.net>.
Ben Collins-Sussman <su...@newton.ch.collab.net> writes:
> Sorry about this; this was an intentional breakage. It's a big
> change, and we'll finish fixing it today.
But let's try to remember:
If you consciously break the build, please state so _prominently_ in
your commit message, so anyone casually reviewing the logs (say,
because they can't build) will see the notice.
-K
> "B. W. Fitzpatrick" <fi...@red-bean.com> writes:
>
> > Finally decided to start poking around in the filesystem and can't get
> > it to build. Applied Yoshiki's patch to dag.h first. Up to date
> > working copy and clean build.
> >
> > $ cvs up -d
> > $ make distclean
> > $ ./autogen.sh && ./configure --with-maintainer-mode \
> > --disable-shared \
> > --with-berkeley-db=/usr/local/BerkeleyDB.3.2 \
> > && make
> >
> > <massive elision>...
> > Making all in libsvn_fs
> > make[3]: Entering directory `/disk/hdb1/bwf/cvs-work/subversion/subversion/libsvn_fs'
> > /bin/sh ../../libtool --silent --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../subversion/include -I../../apr/include -I../../expat-lite -D_REENTRANT -I/usr/local/BerkeleyDB.3.2/include -pthread -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -Wshadow -DSVN_DEBUG -DAP_DEBUG -g -Wall -c dag.c
> > dag.c: In function `find_dir_entry':
> > dag.c:229: structure has no member named `contents'
> > dag.c:238: structure has no member named `contents'
> > dag.c:242: structure has no member named `entry'
> > dag.c: In function `node_is_kind_p':
> > dag.c:264: structure has no member named `contents'
> > dag.c: In function `svn_fs__dag_is_mutable':
> > dag.c:315: structure has no member named `contents'
> > dag.c: In function `svn_fs__dag_get_proplist':
> > dag.c:328: structure has no member named `contents'
> > dag.c: In function `svn_fs__dag_set_proplist':
> > dag.c:382: structure has no member named `contents'
> > dag.c: In function `svn_fs__dag_revision_root':
> > dag.c:416: structure has no member named `contents'
> > dag.c: In function `svn_fs__dag_txn_root':
> > dag.c:440: structure has no member named `contents'
> > dag.c: In function `svn_fs__dag_clone_child':
> > dag.c:486: structure has no member named `contents'
> > dag.c:503: structure has no member named `contents'
> > dag.c:503: structure has no member named `contents'
> > dag.c: In function `svn_fs__dag_clone_root':
> > dag.c:557: structure has no member named `contents'
> > dag.c: In function `svn_fs__dag_delete':
> > dag.c:599: structure has no member named `contents'
> > dag.c: In function `make_entry':
> > dag.c:812: structure has no member named `contents'
> > dag.c: In function `svn_fs__dag_set_contents':
> > dag.c:863: structure has no member named `contents'
> > dag.c: In function `svn_fs__dag_open':
> > dag.c:947: structure has no member named `contents'
> > dag.c: At top level:
> > dag.c:168: warning: `get_node_revision_cached' defined but not used
> > dag.c:193: warning: `set_node_revision_cached' defined but not used
> > make[3]: *** [dag.lo] Error 1
> > make[3]: Leaving directory `/disk/hdb1/bwf/cvs-work/subversion/subversion/libsvn_fs'
> > make[2]: *** [all-recursive] Error 1
> > make[2]: Leaving directory `/disk/hdb1/bwf/cvs-work/subversion/subversion'
> > make[1]: *** [all-recursive] Error 1
> > make[1]: Leaving directory `/disk/hdb1/bwf/cvs-work/subversion'
> > make: *** [all-recursive-am] Error 2
> > ..cvs-work/subversion$
> >
> >
> > Am I missing something?
> >
> > -Fitz
Re: filesystem build broken or is it just me?
Posted by Ben Collins-Sussman <su...@newton.ch.collab.net>.
Sorry about this; this was an intentional breakage. It's a big
change, and we'll finish fixing it today.
"B. W. Fitzpatrick" <fi...@red-bean.com> writes:
> Finally decided to start poking around in the filesystem and can't get
> it to build. Applied Yoshiki's patch to dag.h first. Up to date
> working copy and clean build.
>
> $ cvs up -d
> $ make distclean
> $ ./autogen.sh && ./configure --with-maintainer-mode \
> --disable-shared \
> --with-berkeley-db=/usr/local/BerkeleyDB.3.2 \
> && make
>
> <massive elision>...
> Making all in libsvn_fs
> make[3]: Entering directory `/disk/hdb1/bwf/cvs-work/subversion/subversion/libsvn_fs'
> /bin/sh ../../libtool --silent --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../subversion/include -I../../apr/include -I../../expat-lite -D_REENTRANT -I/usr/local/BerkeleyDB.3.2/include -pthread -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -Wshadow -DSVN_DEBUG -DAP_DEBUG -g -Wall -c dag.c
> dag.c: In function `find_dir_entry':
> dag.c:229: structure has no member named `contents'
> dag.c:238: structure has no member named `contents'
> dag.c:242: structure has no member named `entry'
> dag.c: In function `node_is_kind_p':
> dag.c:264: structure has no member named `contents'
> dag.c: In function `svn_fs__dag_is_mutable':
> dag.c:315: structure has no member named `contents'
> dag.c: In function `svn_fs__dag_get_proplist':
> dag.c:328: structure has no member named `contents'
> dag.c: In function `svn_fs__dag_set_proplist':
> dag.c:382: structure has no member named `contents'
> dag.c: In function `svn_fs__dag_revision_root':
> dag.c:416: structure has no member named `contents'
> dag.c: In function `svn_fs__dag_txn_root':
> dag.c:440: structure has no member named `contents'
> dag.c: In function `svn_fs__dag_clone_child':
> dag.c:486: structure has no member named `contents'
> dag.c:503: structure has no member named `contents'
> dag.c:503: structure has no member named `contents'
> dag.c: In function `svn_fs__dag_clone_root':
> dag.c:557: structure has no member named `contents'
> dag.c: In function `svn_fs__dag_delete':
> dag.c:599: structure has no member named `contents'
> dag.c: In function `make_entry':
> dag.c:812: structure has no member named `contents'
> dag.c: In function `svn_fs__dag_set_contents':
> dag.c:863: structure has no member named `contents'
> dag.c: In function `svn_fs__dag_open':
> dag.c:947: structure has no member named `contents'
> dag.c: At top level:
> dag.c:168: warning: `get_node_revision_cached' defined but not used
> dag.c:193: warning: `set_node_revision_cached' defined but not used
> make[3]: *** [dag.lo] Error 1
> make[3]: Leaving directory `/disk/hdb1/bwf/cvs-work/subversion/subversion/libsvn_fs'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/disk/hdb1/bwf/cvs-work/subversion/subversion'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/disk/hdb1/bwf/cvs-work/subversion'
> make: *** [all-recursive-am] Error 2
> ..cvs-work/subversion$
>
>
> Am I missing something?
>
> -Fitz