You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/11/05 22:42:13 UTC
Review Request 63564: Migrate from findbugs to spotbugs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63564/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Findbugs [1] is no longer developed and replaced by spotbugs [2]
as mostly a drop-in replacement.
[1] https://github.com/findbugsproject/findbugs
[2] https://mailman.cs.umd.edu/pipermail/findbugs-discuss/2017-September/004383.html
Diffs
-----
build.gradle 26051ac9267060606a5a4e05a1ac432c1ff4c79b
config/findbugs/excludeFilter.xml 4d5b36f0c9ae9312ba6afdc6f0b4a42ab0c2dc2b
src/main/java/org/apache/aurora/scheduler/offers/OfferOrderBuilder.java 2676da0a4aba3ff4afc7801dfd8f9d16918d87ff
Diff: https://reviews.apache.org/r/63564/diff/1/
Testing
-------
Thanks,
Stephan Erb
Re: Review Request 63564: Migrate from findbugs to spotbugs
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63564/#review190110
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Nov. 5, 2017, 2:42 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63564/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2017, 2:42 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Findbugs [1] is no longer developed and replaced by spotbugs [2]
> as mostly a drop-in replacement.
>
> [1] https://github.com/findbugsproject/findbugs
> [2] https://mailman.cs.umd.edu/pipermail/findbugs-discuss/2017-September/004383.html
>
>
> Diffs
> -----
>
> build.gradle 26051ac9267060606a5a4e05a1ac432c1ff4c79b
> config/findbugs/excludeFilter.xml 4d5b36f0c9ae9312ba6afdc6f0b4a42ab0c2dc2b
> src/main/java/org/apache/aurora/scheduler/offers/OfferOrderBuilder.java 2676da0a4aba3ff4afc7801dfd8f9d16918d87ff
>
>
> Diff: https://reviews.apache.org/r/63564/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 63564: Migrate from findbugs to spotbugs
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63564/#review190109
-----------------------------------------------------------
Master (d101655) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 5, 2017, 10:42 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63564/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2017, 10:42 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Findbugs [1] is no longer developed and replaced by spotbugs [2]
> as mostly a drop-in replacement.
>
> [1] https://github.com/findbugsproject/findbugs
> [2] https://mailman.cs.umd.edu/pipermail/findbugs-discuss/2017-September/004383.html
>
>
> Diffs
> -----
>
> build.gradle 26051ac9267060606a5a4e05a1ac432c1ff4c79b
> config/findbugs/excludeFilter.xml 4d5b36f0c9ae9312ba6afdc6f0b4a42ab0c2dc2b
> src/main/java/org/apache/aurora/scheduler/offers/OfferOrderBuilder.java 2676da0a4aba3ff4afc7801dfd8f9d16918d87ff
>
>
> Diff: https://reviews.apache.org/r/63564/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stephan Erb
>
>