[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1184: CASSANDRA-16911 - remove ephemeral marker file for snapshot

[GitBox <gi...@apache.org>]

smiklosovic commented on code in PR #1184:
URL: https://github.com/apache/cassandra/pull/1184#discussion_r913027324


##########
test/distributed/org/apache/cassandra/distributed/impl/Instance.java:
##########
@@ -620,6 +621,19 @@ public void startup(ICluster cluster)
                 // Start up virtual table support
                 CassandraDaemon.getInstanceForTesting().setupVirtualKeyspaces();
 
+                // clean up debris in the rest of the keyspaces
+                for (String keyspaceName : Schema.instance.getKeyspaces())

Review Comment:
   this needs to be here, actually, it should be here already. if you see what this method does, it basically copies what is in CassandraDaemon setup minus some details. I followed that method closely and this is what was missing. Without this, it will not trigger the code which scrubs data dirs / removes ephemerals.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org