You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/11/19 21:33:03 UTC

[GitHub] spark pull request #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22237#discussion_r234789275
  
    --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
    @@ -1694,7 +1694,7 @@ test_that("column functions", {
       df <- as.DataFrame(list(list("col" = "{\"date\":\"21/10/2014\"}")))
       schema2 <- structType(structField("date", "date"))
       s <- collect(select(df, from_json(df$col, schema2)))
    -  expect_equal(s[[1]][[1]], NA)
    +  expect_equal(s[[1]][[1]]$date, NA)
    --- End diff --
    
    What is the reason we made this change?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org