[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #3020: Test camel-xchange with kraken until binance issues are resolved

[GitBox <gi...@apache.org>]

jamesnetherton commented on a change in pull request #3020:
URL: https://github.com/apache/camel-quarkus/pull/3020#discussion_r692157956



##########
File path: extensions/xchange/deployment/src/main/java/org/apache/camel/quarkus/component/xchange/deployment/XchangeProcessor.java
##########
@@ -97,9 +97,9 @@ void registerForReflection(BuildProducer<ReflectiveClassBuildItem> reflectiveCla
         String[] dtoClasses = index.getKnownClasses()
                 .stream()
                 .map(classInfo -> classInfo.name().toString())
-                .filter(className -> className.startsWith("org.knowm.xchange.dto"))
+                .filter(className -> className.matches("^org\\.knowm\\.xchange.*dto.*"))

Review comment:
       The problem is that users can choose from a multitude of different crypto exchanges and there is no real consistency among the xchange libs in terms of how the package names are defined. The only common element is that they start with `org.knowm.xchange` and have `dto` somewhere in the remainder of the name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org