[GitHub] [superset] geido commented on pull request #17792: feat: support color consistency

[GitBox <gi...@apache.org>]

geido commented on pull request #17792:
URL: https://github.com/apache/superset/pull/17792#issuecomment-998918621


   > For testing purposes, used the virtual table as Dataset. We can see different `value of column` has different color:
   > ```
   > SELECT * FROM 
   > (SELECT 'a' as color, 1 as val
   > UNION 
   > SELECT 'b', 1
   > UNION 
   > SELECT 'c', 1
   > UNION 
   > SELECT 'd', 1
   > UNION 
   > SELECT 'e', 1
   > UNION
   > SELECT 'f', 1
   > UNION 
   > SELECT 'g', 1
   > UNION 
   > SELECT 'h', 1
   > UNION 
   > SELECT 'i', 1
   > UNION
   > SELECT 'j', 1
   > UNION 
   > SELECT 'k', 1
   > UNION 
   > SELECT 'l', 1
   > UNION 
   > SELECT 'm', 1
   > UNION
   > SELECT 'n', 1
   > UNION 
   > SELECT 'o', 1
   > UNION 
   > SELECT 'p', 1
   > UNION 
   > SELECT 'q', 1
   > UNION
   > SELECT 'r', 1
   > UNION 
   > SELECT 's', 1
   > UNION 
   > SELECT 't', 1
   > UNION 
   > SELECT 'u', 1
   > UNION
   > SELECT 'v', 1
   > UNION
   > SELECT 'w', 1
   > UNION 
   > SELECT 'x', 1
   > UNION 
   > SELECT 'y', 1
   > UNION 
   > SELECT 'z', 1
   > ) as _view
   > ORDER BY COLOR
   > ```
   > 
   > 1. Create virtual dataset in the SQLLab.
   > 2. Create a Pie Chart 1) `count(*)` as metric 2) `color` as groupby 3) `a,b,c` in filter, save as new chart and create a dashboard.
   > 3. Create a Pie Chart 1) `count(*)` as metric 2) `color` as groupby 3) `d,e,f` in filter, save as new chart and insert into previous dashboard.
   > 
   > ### In this PR
   > <img width="1320" alt="image" src="https://user-images.githubusercontent.com/2016594/146934563-883847d8-eaba-436a-a0a7-f430c77375f9.png">
   > 
   > ### Current master(19daf65b5)
   > <img width="1312" alt="image" src="https://user-images.githubusercontent.com/2016594/146935001-0dd9fddd-8684-4a82-b4fd-3439d743bd59.png">
   > 
   > 
   
   You are right @zhaoyongjie that's because this PR brings back sharing the same color instance across all the charts of a dashboard, as I mentioned in a comment above. However, @stephenLYZ said that is for testing only, so I assume it will be reverted soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org