You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/02 17:22:26 UTC
[GitHub] [hudi] nfarah86 opened a new pull request, #7120: Edit quickstart
nfarah86 opened a new pull request, #7120:
URL: https://github.com/apache/hudi/pull/7120
### Change Logs
Updated and fix a few things for the Python side:
1. Updated time travel query to have the right format
2. Fixed copy issue for hard and soft deletes
3. Minor stylistic changes
### Impact
Doc changes/ improved user experience for python
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nfarah86 commented on pull request #7120: Edit quickstart
Posted by GitBox <gi...@apache.org>.
nfarah86 commented on PR #7120:
URL: https://github.com/apache/hudi/pull/7120#issuecomment-1300967891
@bhasudha please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha commented on a diff in pull request #7120: [DOCS] Edit quickstart
Posted by GitBox <gi...@apache.org>.
bhasudha commented on code in PR #7120:
URL: https://github.com/apache/hudi/pull/7120#discussion_r1012138734
##########
website/docs/quick-start-guide.md:
##########
@@ -1155,7 +1163,13 @@ delete from hudi_cow_pt_tbl where name = 'a1';
</TabItem>
<TabItem value="python">
-Delete records for the HoodieKeys passed in.<br/>
+
+#### Code overview
Review Comment:
This seems like redundant info already available in the lines 962 - 965 above. Do we need this specifically for Python tab?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha commented on a diff in pull request #7120: [DOCS] Edit quickstart
Posted by GitBox <gi...@apache.org>.
bhasudha commented on code in PR #7120:
URL: https://github.com/apache/hudi/pull/7120#discussion_r1012148242
##########
website/docs/quick-start-guide.md:
##########
@@ -1028,6 +1028,13 @@ Notice that the save mode is `Append`.
</TabItem>
<TabItem value="python">
+#### Code overview
+Soft deletes retain the record key and null out the values for all the other fields. For example, records with nulls in soft deletes are always persisted in storage and never removed.<br/><br/>
Review Comment:
Makes sense. Nadine and I synced on this offline. We will pull this out of individual tabs and add a brief description under hard deletes section for better readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha commented on a diff in pull request #7120: [DOCS] Edit quickstart
Posted by GitBox <gi...@apache.org>.
bhasudha commented on code in PR #7120:
URL: https://github.com/apache/hudi/pull/7120#discussion_r1012138929
##########
website/docs/quick-start-guide.md:
##########
@@ -1028,6 +1028,13 @@ Notice that the save mode is `Append`.
</TabItem>
<TabItem value="python">
+#### Code overview
+Soft deletes retain the record key and null out the values for all the other fields. For example, records with nulls in soft deletes are always persisted in storage and never removed.<br/><br/>
Review Comment:
This seems like redundant info already available in the lines 962 - 965 above. Do we need this specifically for Python tab?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nfarah86 commented on a diff in pull request #7120: [DOCS] Edit quickstart
Posted by GitBox <gi...@apache.org>.
nfarah86 commented on code in PR #7120:
URL: https://github.com/apache/hudi/pull/7120#discussion_r1012139973
##########
website/docs/quick-start-guide.md:
##########
@@ -1155,7 +1163,13 @@ delete from hudi_cow_pt_tbl where name = 'a1';
</TabItem>
<TabItem value="python">
-Delete records for the HoodieKeys passed in.<br/>
+
+#### Code overview
Review Comment:
This is just like a friendly reminder about the code below, so user doesn't have to scroll up and refresh
##########
website/docs/quick-start-guide.md:
##########
@@ -1028,6 +1028,13 @@ Notice that the save mode is `Append`.
</TabItem>
<TabItem value="python">
+#### Code overview
+Soft deletes retain the record key and null out the values for all the other fields. For example, records with nulls in soft deletes are always persisted in storage and never removed.<br/><br/>
Review Comment:
This is just like a friendly reminder about the code below, so user doesn't have to scroll up and refresh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha merged pull request #7120: [DOCS] Edit quickstart
Posted by GitBox <gi...@apache.org>.
bhasudha merged PR #7120:
URL: https://github.com/apache/hudi/pull/7120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org