You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "olivier dupuy (JIRA)" <ji...@apache.org> on 2009/10/26 18:57:50 UTC

[jira] Created: (WW-3299) XML validation issue on struts-tags.tld for which should be in X.Y format instead of X.Y.Z

XML validation issue on struts-tags.tld for <tlib-version> which should be in X.Y format instead of X.Y.Z
---------------------------------------------------------------------------------------------------------

                 Key: WW-3299
                 URL: https://issues.apache.org/struts/browse/WW-3299
             Project: Struts 2
          Issue Type: Bug
    Affects Versions: 2.1.6
         Environment: Any
            Reporter: olivier dupuy
            Priority: Minor


Hi

I use struts 2.1.6
If I add struts-stags.tld to my project in WEB-INF as it is perfectly legal and referring it in web.xml and if I validate the TLD I get an error on <tlib-version>2.2.3</tlib-version>

My IDE, RSA 7.0.8 built on Eclipse 3.4 I think gives me the errors
cvc-datatype-valid.1.2.1: '2.2.3' is not a valid value for 'decimal'.
cvc-type.3.1.3: The value '2.2.3' of element 'tlib-version' is not valid.

If you open the XSD given at the top of the TLD file http://java.sun.com/xml/ns/j2ee/web-jsptaglibrary_2_0.xsd

You will find the following definition for 
   <xsd:sequence>
      <xsd:group ref="j2ee:descriptionGroup"/>
      <xsd:element name="tlib-version"
		   type="j2ee:dewey-versionType">
	<xsd:annotation>
	  <xsd:documentation>

	    Describes this version (number) of the taglibrary.
	    It is described as a dewey decimal.

	  </xsd:documentation>
	</xsd:annotation>

A "Dewey" number, used in libraries and others has only one decimal, see http://en.wikipedia.org/wiki/Dewey_Decimal_Classification

So obviously the number should have a format X.Y and not X.Y.Z, I made the change locally and it works.

Thanks

Olivier

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3299) XML validation issue on struts-tags.tld for which should be in X.Y format instead of X.Y.Z

Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46969#action_46969 ] 

Musachy Barroso commented on WW-3299:
-------------------------------------

This has been discussed before, x.y.z is allowed by the jsp spec (section JSP.C.4DTD for TLD, JSP 1.1):

<!--
The taglib tag is the document root, it defines:
tlibversion the version of the tag library implementation
jspversion the version of JSP the tag library depends upon
shortname a simple default short name that could be used by a JSP authoring
tool to create names with a mnemonic value; for example, the it may be used as
the prefered prefix value in taglib directives
uri            a uri uniquely identifying this taglib
info           a simple string describing the "use" of this taglib, should be user dis-
cernable
-->
<!ELEMENT taglib (tlibversion, jspversion?, shortname, uri?, info?, tag+) >
<!ATTLIST taglib id ID #IMPLIED
      xmlns CDATA #FIXED
     "http://java.sun.com/dtd/web-jsptaglibrary_1_1.dtd"
>
<!--
Describes this version (number) of the taglibrary (dewey decimal)
#PCDATA ::= [0-9]*{ "."[0-9] }0..3
-->


> XML validation issue on struts-tags.tld for <tlib-version> which should be in X.Y format instead of X.Y.Z
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3299
>                 URL: https://issues.apache.org/struts/browse/WW-3299
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.6
>         Environment: Any
>            Reporter: olivier dupuy
>            Priority: Minor
>
> Hi
> I use struts 2.1.6
> If I add struts-stags.tld to my project in WEB-INF as it is perfectly legal and referring it in web.xml and if I validate the TLD I get an error on <tlib-version>2.2.3</tlib-version>
> My IDE, RSA 7.0.8 built on Eclipse 3.4 I think gives me the errors
> cvc-datatype-valid.1.2.1: '2.2.3' is not a valid value for 'decimal'.
> cvc-type.3.1.3: The value '2.2.3' of element 'tlib-version' is not valid.
> If you open the XSD given at the top of the TLD file http://java.sun.com/xml/ns/j2ee/web-jsptaglibrary_2_0.xsd
> You will find the following definition for 
>    <xsd:sequence>
>       <xsd:group ref="j2ee:descriptionGroup"/>
>       <xsd:element name="tlib-version"
> 		   type="j2ee:dewey-versionType">
> 	<xsd:annotation>
> 	  <xsd:documentation>
> 	    Describes this version (number) of the taglibrary.
> 	    It is described as a dewey decimal.
> 	  </xsd:documentation>
> 	</xsd:annotation>
> A "Dewey" number, used in libraries and others has only one decimal, see http://en.wikipedia.org/wiki/Dewey_Decimal_Classification
> So obviously the number should have a format X.Y and not X.Y.Z, I made the change locally and it works.
> Thanks
> Olivier

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3299) XML validation issue on struts-tags.tld for which should be in X.Y format instead of X.Y.Z

Posted by "olivier dupuy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46971#action_46971 ] 

olivier dupuy commented on WW-3299:
-----------------------------------

Thanks Musachy,
OK, so in theory multiple groups are authorized. In practice, my IDE fails the validation.
This could be a good idea to have the tlib version matching the struts version except if there is no change in the tags from the previous version. I am not sure to what 2.3.3 refers to, not a struts version obviously.

Thanks

> XML validation issue on struts-tags.tld for <tlib-version> which should be in X.Y format instead of X.Y.Z
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3299
>                 URL: https://issues.apache.org/struts/browse/WW-3299
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.6
>         Environment: Any
>            Reporter: olivier dupuy
>            Priority: Minor
>
> Hi
> I use struts 2.1.6
> If I add struts-stags.tld to my project in WEB-INF as it is perfectly legal and referring it in web.xml and if I validate the TLD I get an error on <tlib-version>2.2.3</tlib-version>
> My IDE, RSA 7.0.8 built on Eclipse 3.4 I think gives me the errors
> cvc-datatype-valid.1.2.1: '2.2.3' is not a valid value for 'decimal'.
> cvc-type.3.1.3: The value '2.2.3' of element 'tlib-version' is not valid.
> If you open the XSD given at the top of the TLD file http://java.sun.com/xml/ns/j2ee/web-jsptaglibrary_2_0.xsd
> You will find the following definition for 
>    <xsd:sequence>
>       <xsd:group ref="j2ee:descriptionGroup"/>
>       <xsd:element name="tlib-version"
> 		   type="j2ee:dewey-versionType">
> 	<xsd:annotation>
> 	  <xsd:documentation>
> 	    Describes this version (number) of the taglibrary.
> 	    It is described as a dewey decimal.
> 	  </xsd:documentation>
> 	</xsd:annotation>
> A "Dewey" number, used in libraries and others has only one decimal, see http://en.wikipedia.org/wiki/Dewey_Decimal_Classification
> So obviously the number should have a format X.Y and not X.Y.Z, I made the change locally and it works.
> Thanks
> Olivier

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WW-3299) XML validation issue on struts-tags.tld for which should be in X.Y format instead of X.Y.Z

Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Musachy Barroso resolved WW-3299.
---------------------------------

    Resolution: Not A Problem

see comments

> XML validation issue on struts-tags.tld for <tlib-version> which should be in X.Y format instead of X.Y.Z
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3299
>                 URL: https://issues.apache.org/struts/browse/WW-3299
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.6
>         Environment: Any
>            Reporter: olivier dupuy
>            Priority: Minor
>
> Hi
> I use struts 2.1.6
> If I add struts-stags.tld to my project in WEB-INF as it is perfectly legal and referring it in web.xml and if I validate the TLD I get an error on <tlib-version>2.2.3</tlib-version>
> My IDE, RSA 7.0.8 built on Eclipse 3.4 I think gives me the errors
> cvc-datatype-valid.1.2.1: '2.2.3' is not a valid value for 'decimal'.
> cvc-type.3.1.3: The value '2.2.3' of element 'tlib-version' is not valid.
> If you open the XSD given at the top of the TLD file http://java.sun.com/xml/ns/j2ee/web-jsptaglibrary_2_0.xsd
> You will find the following definition for 
>    <xsd:sequence>
>       <xsd:group ref="j2ee:descriptionGroup"/>
>       <xsd:element name="tlib-version"
> 		   type="j2ee:dewey-versionType">
> 	<xsd:annotation>
> 	  <xsd:documentation>
> 	    Describes this version (number) of the taglibrary.
> 	    It is described as a dewey decimal.
> 	  </xsd:documentation>
> 	</xsd:annotation>
> A "Dewey" number, used in libraries and others has only one decimal, see http://en.wikipedia.org/wiki/Dewey_Decimal_Classification
> So obviously the number should have a format X.Y and not X.Y.Z, I made the change locally and it works.
> Thanks
> Olivier

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-3299) XML validation issue on struts-tags.tld for which should be in X.Y format instead of X.Y.Z

Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Musachy Barroso updated WW-3299:
--------------------------------

    Fix Version/s: 2.2.0

> XML validation issue on struts-tags.tld for <tlib-version> which should be in X.Y format instead of X.Y.Z
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3299
>                 URL: https://issues.apache.org/struts/browse/WW-3299
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.6
>         Environment: Any
>            Reporter: olivier dupuy
>            Priority: Minor
>             Fix For: 2.2.0
>
>
> Hi
> I use struts 2.1.6
> If I add struts-stags.tld to my project in WEB-INF as it is perfectly legal and referring it in web.xml and if I validate the TLD I get an error on <tlib-version>2.2.3</tlib-version>
> My IDE, RSA 7.0.8 built on Eclipse 3.4 I think gives me the errors
> cvc-datatype-valid.1.2.1: '2.2.3' is not a valid value for 'decimal'.
> cvc-type.3.1.3: The value '2.2.3' of element 'tlib-version' is not valid.
> If you open the XSD given at the top of the TLD file http://java.sun.com/xml/ns/j2ee/web-jsptaglibrary_2_0.xsd
> You will find the following definition for 
>    <xsd:sequence>
>       <xsd:group ref="j2ee:descriptionGroup"/>
>       <xsd:element name="tlib-version"
> 		   type="j2ee:dewey-versionType">
> 	<xsd:annotation>
> 	  <xsd:documentation>
> 	    Describes this version (number) of the taglibrary.
> 	    It is described as a dewey decimal.
> 	  </xsd:documentation>
> 	</xsd:annotation>
> A "Dewey" number, used in libraries and others has only one decimal, see http://en.wikipedia.org/wiki/Dewey_Decimal_Classification
> So obviously the number should have a format X.Y and not X.Y.Z, I made the change locally and it works.
> Thanks
> Olivier

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WW-3299) XML validation issue on struts-tags.tld for which should be in X.Y format instead of X.Y.Z

Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Musachy Barroso reopened WW-3299:
---------------------------------


although the version is ok according to spec, I agree with you. I will change it in trunk so this stops failing. It is not like we care about what the version means anyway.

> XML validation issue on struts-tags.tld for <tlib-version> which should be in X.Y format instead of X.Y.Z
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3299
>                 URL: https://issues.apache.org/struts/browse/WW-3299
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.1.6
>         Environment: Any
>            Reporter: olivier dupuy
>            Priority: Minor
>
> Hi
> I use struts 2.1.6
> If I add struts-stags.tld to my project in WEB-INF as it is perfectly legal and referring it in web.xml and if I validate the TLD I get an error on <tlib-version>2.2.3</tlib-version>
> My IDE, RSA 7.0.8 built on Eclipse 3.4 I think gives me the errors
> cvc-datatype-valid.1.2.1: '2.2.3' is not a valid value for 'decimal'.
> cvc-type.3.1.3: The value '2.2.3' of element 'tlib-version' is not valid.
> If you open the XSD given at the top of the TLD file http://java.sun.com/xml/ns/j2ee/web-jsptaglibrary_2_0.xsd
> You will find the following definition for 
>    <xsd:sequence>
>       <xsd:group ref="j2ee:descriptionGroup"/>
>       <xsd:element name="tlib-version"
> 		   type="j2ee:dewey-versionType">
> 	<xsd:annotation>
> 	  <xsd:documentation>
> 	    Describes this version (number) of the taglibrary.
> 	    It is described as a dewey decimal.
> 	  </xsd:documentation>
> 	</xsd:annotation>
> A "Dewey" number, used in libraries and others has only one decimal, see http://en.wikipedia.org/wiki/Dewey_Decimal_Classification
> So obviously the number should have a format X.Y and not X.Y.Z, I made the change locally and it works.
> Thanks
> Olivier

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.