[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #226: Apply Baseline plugin to iceberg-spark

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #226: Apply Baseline plugin to iceberg-spark
URL: https://github.com/apache/incubator-iceberg/pull/226#discussion_r296460624
 
 

 ##########
 File path: spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java
 ##########
 @@ -120,7 +120,7 @@ protected void appendAsFile(Dataset<Row> ds) {
         .save(table.location());
   }
 
-  protected void withSQLConf(Map<String, String> conf, Action action) {
+  protected void withSqlConf(Map<String, String> conf, Action action) {
 
 Review comment:
   If SQL is okay now, then let's revert these changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org