You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/27 14:39:31 UTC

[GitHub] [flink] aljoscha opened a new pull request #12361: [FLINK-13632] Port serializer upgrade tests to TypeSerializerUpgradeTestBase

aljoscha opened a new pull request #12361:
URL: https://github.com/apache/flink/pull/12361


   ## What is the purpose of the change
   
   We migrate all serializer upgrade tests from `TypeSerializerSnapshotMigrationTestBase` to `TypeSerializerUpgradeTestBase`. Additionally, we add snapshots for Flink 1.11 for all the serializers. This will give us test coverage from 1.11 onward for serializer compatibility.
   
   This is work by @klion26 and me, I am mostly the reviewer but putting up this PR to have a paper trail.
   
   And thanks a lot to @klion26 for working on this gigantic task with me! 🎊
   
   ## Brief change log
   
   - add Flink 1.11 `MigrationVersion`
   - add snapshots for Flink 1.11, these are from the code added in later commits but we add them to the repo first so that the tests never fail afterwards
    - upgrade test base for Flink 1.11
    - convert individual tests
   
   cc @klion26 Could you do a final review?
   cc @tzulitai 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] klion26 commented on pull request #12361: [FLINK-13632] Port serializer upgrade tests to TypeSerializerUpgradeTestBase

Posted by GitBox <gi...@apache.org>.
klion26 commented on pull request #12361:
URL: https://github.com/apache/flink/pull/12361#issuecomment-635055657


   @aljoscha thanks for the great work, LGTM % the minor question on #12363 
   The test failed because of FLINK-16572


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12361: [FLINK-13632] Port serializer upgrade tests to TypeSerializerUpgradeTestBase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12361:
URL: https://github.com/apache/flink/pull/12361#issuecomment-634735899


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "956eb8c52c2e828b82a04f8cd41d984cc7a4d9bf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2296",
       "triggerID" : "956eb8c52c2e828b82a04f8cd41d984cc7a4d9bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 956eb8c52c2e828b82a04f8cd41d984cc7a4d9bf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2296) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12361: [FLINK-13632] Port serializer upgrade tests to TypeSerializerUpgradeTestBase

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12361:
URL: https://github.com/apache/flink/pull/12361#issuecomment-634717128


   This is a version of #12363 for the `release-1.11` branch. Maybe we don't need to merge this in the end.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12361: [FLINK-13632] Port serializer upgrade tests to TypeSerializerUpgradeTestBase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12361:
URL: https://github.com/apache/flink/pull/12361#issuecomment-634735899


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "956eb8c52c2e828b82a04f8cd41d984cc7a4d9bf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2296",
       "triggerID" : "956eb8c52c2e828b82a04f8cd41d984cc7a4d9bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 956eb8c52c2e828b82a04f8cd41d984cc7a4d9bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2296) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12361: [FLINK-13632] Port serializer upgrade tests to TypeSerializerUpgradeTestBase

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12361:
URL: https://github.com/apache/flink/pull/12361#issuecomment-634735899


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "956eb8c52c2e828b82a04f8cd41d984cc7a4d9bf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "956eb8c52c2e828b82a04f8cd41d984cc7a4d9bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 956eb8c52c2e828b82a04f8cd41d984cc7a4d9bf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12361: [FLINK-13632] Port serializer upgrade tests to TypeSerializerUpgradeTestBase

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12361:
URL: https://github.com/apache/flink/pull/12361#issuecomment-634708030


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 956eb8c52c2e828b82a04f8cd41d984cc7a4d9bf (Wed May 27 14:41:38 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org