You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "handreyrc (via GitHub)" <gi...@apache.org> on 2024/12/02 00:33:47 UTC
[I] SWF-Editor: Handle multiple setContent calls context [incubator-kie-issues]
handreyrc opened a new issue, #1657:
URL: https://github.com/apache/incubator-kie-issues/issues/1657
*Summary*
-----
The goal of this task is to handle workflow's context in the scenarios of loading a workflow for the very first time, reload the workflow, and load a new workflow. It is necessary to keep track of certain information about the workflow in between reloads.
*Description*
-----
When the setContent is called to set the workflow content to be parsed and then rendered, it is necessary to assertain the following scenarios:
- It is a new workflow that is being opened for the first time. This condition is met when there is no previous workflow loaded in the current session of the editor or if it is a different workflow being loaded (workflow id).
- There is a workflow loaded and the we have an updated content for the same workflow ( workflow id).
In the first scenario consider a fresh start for the editor session. If there is a different worflow loaded previously the proper clean ups shall be done berore loading a new workflow.
- reset zoom ratio to initial values
- Clear cached node ids
- Clear Errors stored in the error handler component on every iteration
In the second scenario where new content to the same workflow is being set through setContent the following contexts shall be handled:
- The node ids shall remain the same after reloading the diagram otherwise we lose track of the previous nodes status, for isntance, reselect the same node from the previous loaded workflow. Use unique node names as key, if it is not possible to locate a node it shall be removed from the cache, it it is a new node a new id shall be generated and the id added to the cache for the next iterations.
- The zoom reatio and scroll bars shall remain the same after the reload.
- Errors shall be cleared on every iteration once the new content will be fully evaluated.
Note: Keep in mind that selection and highlight features will depend on this feature once we need to set the same selected node and / or highlited nodes again if the same workflow is reloaded.
*Testing*
-----
Run the component and reload a new content for the same worlfow from the storybook change the zoom and move the scroll bars. Zoom ratio and bars position shall be preserved in between same workflow reloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] SWF-Editor: Handle multiple setContent calls context [incubator-kie-issues]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento closed issue #1657: SWF-Editor: Handle multiple setContent calls context
URL: https://github.com/apache/incubator-kie-issues/issues/1657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] SWF-Editor: Handle multiple setContent calls context [incubator-kie-issues]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on issue #1657:
URL: https://github.com/apache/incubator-kie-issues/issues/1657#issuecomment-4920105163
Closing due to https://github.com/apache/incubator-kie-tools/pull/3540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org