You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by ro...@apache.org on 2026/07/08 08:01:20 UTC
(uniffle) branch master updated: [#2761] fix(spark): remove unnecessary synchronized (#2762)
This is an automated email from the ASF dual-hosted git repository.
roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new 018ac2896 [#2761] fix(spark): remove unnecessary synchronized (#2762)
018ac2896 is described below
commit 018ac289687079defee1c0631bb9c3ad96c0f58c
Author: Zhen Wang <64...@qq.com>
AuthorDate: Wed Jul 8 16:01:14 2026 +0800
[#2761] fix(spark): remove unnecessary synchronized (#2762)
### What changes were proposed in this pull request?
Remove unnecessary synchronized for getRemoteShuffleHandleInfo methods
### Why are the changes needed?
closes #2761
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests
---
.../apache/uniffle/shuffle/manager/RssShuffleManagerBase.java | 4 ++--
.../uniffle/client/impl/FailedBlockSendTrackerTest.java | 11 +----------
2 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/RssShuffleManagerBase.java b/client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/RssShuffleManagerBase.java
index 30e13d422..8f51bede5 100644
--- a/client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/RssShuffleManagerBase.java
+++ b/client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/RssShuffleManagerBase.java
@@ -949,7 +949,7 @@ public abstract class RssShuffleManagerBase implements RssShuffleManagerInterfac
* @param shuffleId shuffleId
* @return ShuffleHandleInfo
*/
- protected synchronized StageAttemptShuffleHandleInfo getRemoteShuffleHandleInfoWithStageRetry(
+ protected StageAttemptShuffleHandleInfo getRemoteShuffleHandleInfoWithStageRetry(
int stageAttemptId, int stageAttemptNumber, int shuffleId, boolean isWritePhase) {
RssPartitionToShuffleServerRequest rssPartitionToShuffleServerRequest =
new RssPartitionToShuffleServerRequest(
@@ -970,7 +970,7 @@ public abstract class RssShuffleManagerBase implements RssShuffleManagerInterfac
* @param shuffleId shuffleId
* @return ShuffleHandleInfo
*/
- protected synchronized MutableShuffleHandleInfo getRemoteShuffleHandleInfoWithBlockRetry(
+ protected MutableShuffleHandleInfo getRemoteShuffleHandleInfoWithBlockRetry(
int stageAttemptId, int stageAttemptNumber, int shuffleId, boolean isWritePhase) {
RssPartitionToShuffleServerRequest rssPartitionToShuffleServerRequest =
new RssPartitionToShuffleServerRequest(
diff --git a/client/src/test/java/org/apache/uniffle/client/impl/FailedBlockSendTrackerTest.java b/client/src/test/java/org/apache/uniffle/client/impl/FailedBlockSendTrackerTest.java
index a5660c4a2..01804781b 100644
--- a/client/src/test/java/org/apache/uniffle/client/impl/FailedBlockSendTrackerTest.java
+++ b/client/src/test/java/org/apache/uniffle/client/impl/FailedBlockSendTrackerTest.java
@@ -82,16 +82,7 @@ public class FailedBlockSendTrackerTest {
ShuffleServerInfo shuffleServerInfo = new ShuffleServerInfo("host1", 19999);
ShuffleBlockInfo shuffleBlockInfo =
new ShuffleBlockInfo(
- 0,
- 0,
- 1L,
- 0,
- 0L,
- new byte[] {},
- Lists.newArrayList(shuffleServerInfo),
- 0,
- 0L,
- 0L);
+ 0, 0, 1L, 0, 0L, new byte[] {}, Lists.newArrayList(shuffleServerInfo), 0, 0L, 0L);
tracker.add(shuffleBlockInfo, shuffleServerInfo, StatusCode.INTERNAL_ERROR);