[GitHub] [kafka] vincent81jiang commented on pull request #11327: KAFKA-13305: fix NullPointerException in LogCleanerManager "uncleanable-bytes" gauge

[GitBox <gi...@apache.org>]

vincent81jiang commented on pull request #11327:
URL: https://github.com/apache/kafka/pull/11327#issuecomment-921219601


   > @junrao @vincent81jiang I wonder if we could remove a partition from the set when the partition is actually deleted instead of using a timer. Would it be possible or perhaps is it not worth it?
   
   @dajac, thanks for the comment.  I think adding a removeCleaning interface to LogCleaner is a good option to consider. I didn't choose this way because in current implementation, the interaction between LogManager and LogCleaner is majored done through the shared "logs" and "logDirs" - like when creating/loading a new log, LogManager doesn't explicit notify LogManager about new log.  Of course this is debatable because there are already interfaces like LogCleaner.abortCleaning/abortAndPauseCleaning/resumeCleaning.   I'd like to know what you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org