[GitHub] [spark] grundprinzip commented on a diff in pull request #42377: [SPARK-44622][SQL][CONNECT] Implement error enrichment and setting server-side stacktrace

["grundprinzip (via GitHub)" <gi...@apache.org>]

grundprinzip commented on code in PR #42377:
URL: https://github.com/apache/spark/pull/42377#discussion_r1329197325


##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -3292,39 +3292,49 @@ def test_stop_session(self):
             self.spark.conf.get("some.conf")
         self._check_no_active_session_error(e.exception)
 
-    def test_error_stack_trace(self):
-        with self.sql_conf({"spark.sql.pyspark.jvmStacktrace.enabled": True}):

Review Comment:
   Doesn't this effectively change the API? What is the expectation when the user sets the SQL conf and moves from py4j to spark connect and back? Shouldn't we retain the option?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org