You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/02/22 09:02:36 UTC

[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1262: [CELEBORN-328][MPROVEMENT] Too much noisy log when reserve slot failed

AngersZhuuuu opened a new pull request, #1262:
URL: https://github.com/apache/incubator-celeborn/pull/1262

   ### What changes were proposed in this pull request?
   ```
   23/02/22 16:38:47 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:47 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:47 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:47 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:48 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:48 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:48 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:48 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:48 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:48 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:49 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:49 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:49 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:49 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:49 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:49 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:49 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:49 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:49 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:49 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:50 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:50 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:50 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:50 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:51 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:51 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:52 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:52 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:52 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:52 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:52 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:52 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:52 ERROR LifecycleManager: OfferSlots for 0 failed!
   23/02/22 16:38:53 ERROR LifecycleManager: OfferSlots for 0 failed!
   ```
   
   Since this message will been print in client side, in driver side we don't need print too much noisy log.
   <img width="1251" alt="截屏2023-02-22 下午4 59 15" src="https://user-images.githubusercontent.com/46485123/220571557-f78140d6-9b0c-4ea3-aca2-47519cbc090c.png">
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1262: [CELEBORN-328][MPROVEMENT] Too much noisy log when reserve slot failed

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1262:
URL: https://github.com/apache/incubator-celeborn/pull/1262#issuecomment-1439669542

   # [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1262?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1262](https://codecov.io/gh/apache/incubator-celeborn/pull/1262?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5992bae) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/decc7a2c3a72c4fa130f67c8c939fdd3ddaa4ed8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (decc7a2) will **increase** coverage by `0.04%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 5992bae differs from pull request most recent head fd6766a. Consider uploading reports for the commit fd6766a to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1262      +/-   ##
   ============================================
   + Coverage     27.07%   27.10%   +0.04%     
   - Complexity      807      811       +4     
   ============================================
     Files           215      215              
     Lines         18360    18360              
     Branches       1999     1999              
   ============================================
   + Hits           4969     4975       +6     
   + Misses        13061    13059       -2     
   + Partials        330      326       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/celeborn/client/LifecycleManager.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY2xpZW50L0xpZmVjeWNsZU1hbmFnZXIuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1262?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `71.73% <0.00%> (+2.46%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture merged pull request #1262: [CELEBORN-328][MPROVEMENT] Too much noisy log when reserve slot failed

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1262:
URL: https://github.com/apache/incubator-celeborn/pull/1262


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org