You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2017/01/16 15:02:37 UTC
[GitHub] activemq-artemis pull request #962: ARTEMIS-560 Add Support For JDBC Paging
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/962
ARTEMIS-560 Add Support For JDBC Paging
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-560
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/962.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #962
----
commit 1e1616e6b88cccd5c7cc31b13863480bb2b802dc
Author: Martyn Taylor <mt...@redhat.com>
Date: 2017-01-12T11:16:48Z
ARTEMIS-560 Add Support For JDBC Paging
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #962: ARTEMIS-560 Add Support For JDBC Paging
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/962
@mtaylor conflict ^^
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #962: ARTEMIS-560 Add Support For JDBC Paging
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/962#discussion_r96415467
--- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFile.java ---
@@ -88,7 +88,12 @@ public boolean isOpen() {
@Override
public boolean exists() {
- return isCreated;
+ if (isCreated) return true;
+ try {
+ return fileFactory.listFiles(extension).contains(filename);
+ } catch (Exception e) {
--- End diff --
This may bite us, can you at least log an error here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #962: ARTEMIS-560 Add Support For JDBC Paging
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/962
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---