You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2017/03/11 00:48:58 UTC
Review Request 57526: Side Nav: several issues tested on IE 11
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57526/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
Bugs: AMBARI-20405
https://issues.apache.org/jira/browse/AMBARI-20405
Repository: ambari
Description
-------
CSS:
1. Active item should have a green triangle at left. Now there was no active effect for menu items except for Admin's submenu.
2. Hovering on Services, service actions icon is invisible. Cannot trigger any service actions.
3. The scrollbar was too prominent, should hide scrollbar on every browser.
JS:
4. Click on Services/Admin menu, no collapse effect. And will go to Service/Admin page.
5. Click on "<<" at the footer, no collapse effect. Cannot collapse side navi menu.
Diffs
-----
ambari-web/app/styles/theme/bootstrap-ambari.css 3adcbe9
ambari-web/vendor/scripts/theme/bootstrap-ambari.js c193f7f
Diff: https://reviews.apache.org/r/57526/diff/1/
Testing
-------
20559 passing (27s)
153 pending
Thanks,
Xi Wang
Re: Review Request 57526: Side Nav: several issues tested on IE 11
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57526/#review168695
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On March 11, 2017, 12:48 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57526/
> -----------------------------------------------------------
>
> (Updated March 11, 2017, 12:48 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-20405
> https://issues.apache.org/jira/browse/AMBARI-20405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> CSS:
> 1. Active item should have a green triangle at left. Now there was no active effect for menu items except for Admin's submenu.
> 2. Hovering on Services, service actions icon is invisible. Cannot trigger any service actions.
> 3. The scrollbar was too prominent, should hide scrollbar on every browser.
>
> JS:
> 4. Click on Services/Admin menu, no collapse effect. And will go to Service/Admin page.
> 5. Click on "<<" at the footer, no collapse effect. Cannot collapse side navi menu.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/theme/bootstrap-ambari.css 3adcbe9
> ambari-web/vendor/scripts/theme/bootstrap-ambari.js c193f7f
>
>
> Diff: https://reviews.apache.org/r/57526/diff/1/
>
>
> Testing
> -------
>
> 20559 passing (27s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 57526: Side Nav: several issues tested on IE 11
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57526/#review168692
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On March 11, 2017, 12:48 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57526/
> -----------------------------------------------------------
>
> (Updated March 11, 2017, 12:48 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-20405
> https://issues.apache.org/jira/browse/AMBARI-20405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> CSS:
> 1. Active item should have a green triangle at left. Now there was no active effect for menu items except for Admin's submenu.
> 2. Hovering on Services, service actions icon is invisible. Cannot trigger any service actions.
> 3. The scrollbar was too prominent, should hide scrollbar on every browser.
>
> JS:
> 4. Click on Services/Admin menu, no collapse effect. And will go to Service/Admin page.
> 5. Click on "<<" at the footer, no collapse effect. Cannot collapse side navi menu.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/theme/bootstrap-ambari.css 3adcbe9
> ambari-web/vendor/scripts/theme/bootstrap-ambari.js c193f7f
>
>
> Diff: https://reviews.apache.org/r/57526/diff/1/
>
>
> Testing
> -------
>
> 20559 passing (27s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>